OpenERP Community Backports (Addons)

Merge lp://staging/~camptocamp/ocb-addons/7.0-bug-1089004-hip into lp://staging/ocb-addons

7.0-bug-1089004-hip
Merge into 7.0

Proposed by Alexandre Fayolle - camptocamp on 2013-02-25

Status:

Merged

Merged at revision:

8784

Proposed branch:

lp://staging/~camptocamp/ocb-addons/7.0-bug-1089004-hip

Merge into:

lp://staging/ocb-addons

Diff against target:

34 lines (+14/-10)

1 file modified

stock/stock_view.xml (+14/-10)

To merge this branch:

bzr merge lp://staging/~camptocamp/ocb-addons/7.0-bug-1089004-hip

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Guewen Baconnier @ Camptocamp	code review, no test		Approve on 2013-02-25
Stefan Rijnhart (Opener)		2013-02-25	Approve on 2013-02-25
Review via email: mp+150300@code.staging.launchpad.net

Description of the change

port the original MP fixing bug lp:1089004 to OCB.

Revision history for this message

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote on 2013-02-25:

I tested the fix and it works fine for me.

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2013-02-25:

LGTM. I suggested in my proposal to always link the bug to specific series so that we can track bugs across multiple series (about 1/3 of all bugs in Therp Backports 6.1 still exist in OpenERP 7.0). Can you do that for this bug? Just navigate to https://bugs.launchpad.net/ocb-addons/+bug/1089004 and click 'Target to Series' -> 7.0

review: Approve

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2013-02-25:

LGTM

review: Approve (code review, no test)

Revision history for this message

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote on 2013-02-25:

> LGTM. I suggested in my proposal to always link the bug to specific series so
> that we can track bugs across multiple series (about 1/3 of all bugs in Therp
> Backports 6.1 still exist in OpenERP 7.0). Can you do that for this bug? Just
> navigate to https://bugs.launchpad.net/ocb-addons/+bug/1089004 and click
> 'Target to Series' -> 7.0

Done. Thanks for the feedback. This is my first OCB MP (probably not the last), and I still need some practise to get it right :-)