Merge lp://staging/~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216 into lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/magentoerpconnect_generic
Proposed by
Nicolas Bessi - Camptocamp
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216 |
| Merge into: | lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/magentoerpconnect_generic |
| Diff against target: |
12 lines (+1/-1) 1 file modified
magerp_core.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~camptocamp/magentoerpconnect/magentoerpconnect_generic_bug_497216 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sharoon Thomas http://openlabs.co.in | Approve | ||
|
Review via email:
|
|||
Commit message
Fix of bug 497216
Description of the change
OK Live and learn, the bug fix is really small, but I had to understand the whole process in order to fix it.
Thanks to everybody for the help.
I hope this one will be good.
Regards Nicolas
To post a comment you must log in.
Revision history for this message
| Sharoon Thomas http://openlabs.co.in (sharoonthomas) wrote | # |
review:
Approve
Revision history for this message
| Sharoon Thomas http://openlabs.co.in (sharoonthomas) wrote | # |
Unmerged revisions
- 296. By Nicolas Bessi - Camptocamp
-
Fix of bug 497216
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The fix looks trivial
(I have not tested it though its the same fix i suggested.)
I think we should wait for two more approvals (Functional & Technical) before merging.
I assume that Your merge proposal can be considered the first functional approval.
So requesting one more approvals before we merge this.