Department Management

Merge lp://staging/~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp://staging/~department-core-editors/department-mgmt/7.0

add-dep-on-project-task-jge
Merge into 7.0

Proposed by Joël Grand-Guillaume @ camptocamp on 2014-04-24

Status:	Merged
Merged at revision:	18
Proposed branch:	lp://staging/~camptocamp/department-mgmt/add-dep-on-project-task-jge
Merge into:	lp://staging/~department-core-editors/department-mgmt/7.0
Diff against target:	114 lines (+81/-2) 4 files modified project_department/__init__.py (+1/-1) project_department/__openerp__.py (+1/-1) project_department/project.py (+39/-0) project_department/project_view.xml (+40/-0)
To merge this branch:	bzr merge lp://staging/~camptocamp/department-mgmt/add-dep-on-project-task-jge
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza	code review	2014-04-24	Approve on 2014-05-08
Guewen Baconnier @ Camptocamp	code review		Approve on 2014-05-08
Review via email: mp+217068@code.staging.launchpad.net

Description of the change

Hi,

This little MP adds the department on tasks (and filter, group by) as a related of the project.

Regards,

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-04-24:

Hi, Joël,

The MP you have done seems good, but I see a little problem: this modification can give the user a false impression that the department is selected by task, and when they try to change it, they get frustrated, because it's readonly.

I advice to change field label to 'Project department' to avoid this confussion.

Regards.

review: Needs Fixing (code review)

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-04-24:

Hi Jöel,

This mainly adds a referenced field for project_id.department_id.
I believe that there is interest in having a future module adding a department_id as a real Task attribute.
Because of this, I support Pedro's opinion on renaming the 'department_id' field to 'project_department_id'.