Department Management

Merge lp://staging/~camptocamp/department-mgmt/7.0-port-crm_department into lp://staging/~department-core-editors/department-mgmt/7.0

  1. 7.0-port-crm_department
  2. Merge into 7.0
Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Merged at revision: 13
Proposed branch: lp://staging/~camptocamp/department-mgmt/7.0-port-crm_department
Merge into: lp://staging/~department-core-editors/department-mgmt/7.0
Diff against target: 394 lines (+151/-159)
4 files modified
crm_department/__init__.py (+3/-2)
crm_department/__openerp__.py (+17/-22)
crm_department/crm.py (+30/-25)
crm_department/crm_view.xml (+101/-110)
To merge this branch: bzr merge lp://staging/~camptocamp/department-mgmt/7.0-port-crm_department
Reviewer Review Type Date Requested Status
Maxime Chambreuil (http://www.savoirfairelinux.com) Approve
Guewen Baconnier @ Camptocamp Approve
Alexandre Fayolle - camptocamp code review, no test Needs Fixing
Review via email: mp+162131@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

line 156: add space after ":"

apart from that LGTM

review: Needs Fixing (code review, no test)
lp://staging/~camptocamp/department-mgmt/7.0-port-crm_department updated
16. By Yannick Vaucher @ Camptocamp

[IMP] crm_department - add a space

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks for the review.

Space add

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches