Merge lp://staging/~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre into lp://staging/banking-addons/bank-statement-reconcile-70
Proposed by
Vincent Renaville@camptocamp
| Status: | Work in progress | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre | ||||
| Merge into: | lp://staging/banking-addons/bank-statement-reconcile-70 | ||||
| Diff against target: |
95 lines (+41/-9) (has conflicts) 1 file modified
statement_voucher_killer/voucher.py (+41/-9) Text conflict in statement_voucher_killer/voucher.py |
||||
| To merge this branch: | bzr merge lp://staging/~camptocamp/banking-addons/bank-statement-reconcile-7.0_voucher_killer_vre | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Pedro Manuel Baeza | code review | Approve | |
| Alexandre Fayolle - camptocamp | Abstain | ||
| Stefan Rijnhart (Opener) | Approve | ||
| Leonardo Pistone | Needs Fixing | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-04-03.
Description of the change
It take the date of the payment line to set the bank statement line instead of maturity date of the payment line
See bug report
To post a comment you must log in.
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Abstain
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Approve
(code review)
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
Unmerged revisions
- 142. By Vincent Renaville@camptocamp
-
[FIX] pep8
- 141. By Vincent Renaville@camptocamp
-
[FIx] set correct date when import payment line into payment order: see bug #1301781
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
To the naked eye, there seems to be a long line. Can you give the comment its own line?
otherwise, il lgtm
thanks!