Merge lp://staging/~camptocamp/anybox.buildbot.openerp/trunk-fix_994523-afe into lp://staging/anybox.buildbot.openerp
Proposed by
Alexandre Fayolle - camptocamp
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~camptocamp/anybox.buildbot.openerp/trunk-fix_994523-afe |
| Merge into: | lp://staging/anybox.buildbot.openerp |
| Diff against target: |
71 lines (+33/-2) 2 files modified
anybox/buildbot/openerp/build_utils/analyze_oerp_tests.py (+29/-0) anybox/buildbot/openerp/subfactories/postbuildout.py (+4/-2) |
| To merge this branch: | bzr merge lp://staging/~camptocamp/anybox.buildbot.openerp/trunk-fix_994523-afe |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Anybox | Pending | ||
|
Review via email:
|
|||
Description of the change
check that requested modules where indeed loaded
this branches adds an awkward way to handle 'openerp-addons = all' by querying the database for installable modules and parsing the output. It assumes that the command line utility psql is available (using psycopg2 would have added a dependency on the python version used to run the analyze script, which is not the one of the buildout)
what this branches shows is that openerp-addons = all does NOT work as intended (other bug reported for this). Now the build is red when using this config :-)
To post a comment you must log in.
Revision history for this message
| Georges Racinet (gracinet) wrote | # |
Unmerged revisions
- 304. By Alexandre Fayolle - camptocamp
-
fix typo
- 303. By Alexandre Fayolle - camptocamp
-
fix sql result parsing
- 302. By Alexandre Fayolle - camptocamp
-
fix typo
- 301. By Alexandre Fayolle - camptocamp
-
attempt to find out what 'all' modules are
- 300. By Alexandre Fayolle - camptocamp
-
[FIX] regexp parsing of loaded modules
- 299. By Alexandre Fayolle - camptocamp
-
[FIX] add test to check that the modules we want to test were installed
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I agree with the usage of psql in that context. I'm doing exactly the same to manage running instances : not depend on psycopg2 for such simple requests to avoid any trouble.
Did you however check that all the relevant environmental variables (PGPORT notably) are passed correcly in that step ? We're using lots of builds on slaves with multiple PostgreSQL versions.
About 'openerp-addons = all', all it does is transmit to the main server script (in the disguise of bin/test_openerp) within the '-i' option, so what you're seeing is a mere reflection of the behaviour of OpenERP itself.