Account - Financial Tools

Merge lp://staging/~camptocamp/account-financial-tools/draft_move_vre_resubmit into lp://staging/~account-core-editors/account-financial-tools/7.0

  1. draft_move_vre_resubmit
  2. Merge into 7.0
Proposed by Vincent Renaville@camptocamp
Status: Rejected
Rejected by: Yannick Vaucher @ Camptocamp
Proposed branch: lp://staging/~camptocamp/account-financial-tools/draft_move_vre_resubmit
Merge into: lp://staging/~account-core-editors/account-financial-tools/7.0
Diff against target: 36 lines (+5/-5)
1 file modified
account_default_draft_move/invoice_view.xml (+5/-5)
To merge this branch: bzr merge lp://staging/~camptocamp/account-financial-tools/draft_move_vre_resubmit
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp Disapprove
Matthieu Dietrich @ camptocamp (community) Needs Resubmitting
Guewen Baconnier @ Camptocamp Pending
Review via email: mp+194673@code.staging.launchpad.net

Description of the change

display invoice cancel button when invoice is open, sale state is not used anymore + Fix change wrong tag Eval for group restriction on customer invoice view

To post a comment you must log in.
Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Sorry for this long wait

I have done a resubmit with a brand new branch.

Vincent

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Your MP is linked with a bug having a 'Fix released' status. Is is another bug or was the bug not fixed?

The comment on line 22 is not inline with the states at line 32.

lp://staging/~camptocamp/account-financial-tools/draft_move_vre_resubmit updated
126. By Vincent Renaville@camptocamp

[FIX] change comment

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hello,

Thanks for the review,
I have made a mistake yesterday, I have remove the bug attached , it's not a bug but much more a code cleaning.

I have correct the comment to fit the code.

Vincent

Revision history for this message
Matthieu Dietrich @ camptocamp (mdietrich-c2c) wrote :

A fix in this branch (eval=) was committed in the main version in another form.

To resolve the conflict, I created lp:~camptocamp/account-financial-tools/draft_move_mdh_resubmit.

review: Needs Resubmitting
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

I reject this as the current changes were merged in
https://code.launchpad.net/~camptocamp/account-financial-tools/draft_move_mdh_resubmit/+merge/199150 with conflict resolution of last changes

review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches