Purchase - Workflow and Organization

Merge lp://staging/~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge into lp://staging/~purchase-core-editors/purchase-wkfl/7.0

  1. purchase_landed_costs-jge
  2. Merge into 7.0
Proposed by Joël Grand-Guillaume @ camptocamp
Status: Merged
Merged at revision: 20
Proposed branch: lp://staging/~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge
Merge into: lp://staging/~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 3121 lines (+3029/-0)
17 files modified
purchase_landed_costs/__init__.py (+29/-0)
purchase_landed_costs/__openerp__.py (+122/-0)
purchase_landed_costs/i18n/fr.po (+375/-0)
purchase_landed_costs/i18n/purchase_landed_costs.pot (+374/-0)
purchase_landed_costs/product.py (+76/-0)
purchase_landed_costs/purchase.py (+632/-0)
purchase_landed_costs/purchase_landed_costs_data.yml (+20/-0)
purchase_landed_costs/purchase_view.xml (+213/-0)
purchase_landed_costs/security/ir.model.access.csv (+5/-0)
purchase_landed_costs/security/landed_cost_security.xml (+13/-0)
purchase_landed_costs/stock.py (+71/-0)
purchase_landed_costs/test/landed_costs_based_on_quantity.yml (+156/-0)
purchase_landed_costs/test/landed_costs_based_on_value.yml (+141/-0)
purchase_landed_costs/test/landed_costs_multicurrency_company.yml (+220/-0)
purchase_landed_costs/test/landed_costs_multicurrency_pricelist.yml (+219/-0)
purchase_landed_costs/test/landed_costs_multicurrency_pricetype.yml (+219/-0)
purchase_landed_costs/test/landed_costs_on_qty_by_line_and_order.yml (+144/-0)
To merge this branch: bzr merge lp://staging/~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) code review Needs Fixing
Review via email: mp+190207@code.staging.launchpad.net

Commit message

[ADD] the module purchase_landed_cost that bring estimated landed cost in PO into the average price computation

Description of the change

Hi there,

This MP adds the purchase_landed_cost module. This module bring the estimated landed costs related to a PO in the average price computation of the product.

It provides various way to enter them and distribute them accross all PO lines (see description of the module for more details). Thanks to Ferdinand Gasauer for the first version in C2C R&D addons and to Savoir Faire Linux to extract it in that branch. I made
quite a lot of changes:

 * Multi-currency properly handled (except the bug found regarding the price_type)
 * Clean the code
 * Make an option to chose or not the invoice generation by landed cost positions from the PO confirmation
 * Add a button to the see all landed cost position from PO
 * Add a reporting view to allow to compare by financial account the estimated cost with real one to allow the valuation of stock in the end of year.
 * Add comments and better description
 * Add tests

Thanks for review !

Regards,

Joël

To post a comment you must log in.
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Thanks Joël.

Same remark I got from Nicolas Bessi:

l29, 30, 31: from . import

;)

review: Needs Fixing (code review)
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Fixed Maxime, thanks !

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi Joël,

Access rules missing on the landed.cost.distribution.type model

My proposition is:

    access_landed_cost,landed.cost.position,model_landed_cost_position,purchase.group_purchase_user,1,1,1,1
    access_landed_cost_distribution_type_user,landed.cost.distribution.type user,model_landed_cost_position,purchase.group_purchase_user,1,0,0,0
    access_landed_cost_distribution_type_manager,landed.cost.distribution manager.type,model_landed_cost_position,purchase.group_purchase_manager,1,1,1,1

review: Needs Fixing
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Done + little fixes

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Improvements and mostly fixes done after strong testing in real use cases

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

minor enhancement pushed

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Fixed a couple of things (pep8, docstrings, osv.except_osv, propagation of context missing)

review: Approve (code review)
lp://staging/~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge updated
20. By Joël Grand-Guillaume @ camptocamp

[ADD] the module purchase_landed_cost that bring estimated landed cost in PO into the average price computation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches