Merge lp://staging/~cameronnemo/apparmor/gnome-abstraction into lp://staging/apparmor/2.12

Proposed by Cameron Norman
Status: Rejected
Rejected by: Steve Beattie
Proposed branch: lp://staging/~cameronnemo/apparmor/gnome-abstraction
Merge into: lp://staging/apparmor/2.12
Diff against target: 21 lines (+4/-0)
1 file modified
profiles/apparmor.d/abstractions/gnome (+4/-0)
To merge this branch: bzr merge lp://staging/~cameronnemo/apparmor/gnome-abstraction
Reviewer Review Type Date Requested Status
intrigeri Disapprove
AppArmor Developers Pending
Review via email: mp+261320@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Boltz (cboltz) wrote :

It seems your merge request somehow got lost, sorry for that!

I'd like to see your added line
+ owner @{HOME}/.config/gtk-3.0/** r,
merged with the existing
   owner @{HOME}/.config/gtk-2.0/** r,
which would result in
   owner @{HOME}/.config/gtk-[23].0/** r,

If you expect the .0 to change, maybe also [23].[0-9].

BTW: I noticed
  owner @{HOME}/.config/gtk-2.0/gtkfilechooser.ini* rw,
Is writing that file also needed with gtk 3? If yes, please also change it to [23].0 or [23].[0-9].

Revision history for this message
intrigeri (intrigeri) wrote :

> I'd like to see your added line
> + owner @{HOME}/.config/gtk-3.0/** r,
> merged with the existing
> owner @{HOME}/.config/gtk-2.0/** r,
> which would result in
> owner @{HOME}/.config/gtk-[23].0/** r,

ACK

> If you expect the .0 to change, maybe also [23].[0-9].

I seriously hope that the GTK project will never introduce config directories versioned in this fine grained a way, and I say we can skip this one.

> BTW: I noticed
> owner @{HOME}/.config/gtk-2.0/gtkfilechooser.ini* rw,
> Is writing that file also needed with gtk 3? If yes, please also change it to
> [23].0 or [23].[0-9].

This file doesn't exist on a modern desktop system that uses GTK+ 3.x intensively, so I don't think it's needed.

Revision history for this message
intrigeri (intrigeri) wrote :

We've been blocking this merge since 1.5 years on a trivial "2 lines that could be merged" issue. One of the proposed changes has been applied independently already, and the other one is very much needed. I'll try to propose a branch that does only the latter change so we can eventually close this MR.

Revision history for this message
intrigeri (intrigeri) wrote :

> We've been blocking this merge since 1.5 years on a trivial "2 lines that
> could be merged" issue. One of the proposed changes has been applied
> independently already, and the other one is very much needed. I'll try to
> propose a branch that does only the latter change so we can eventually close
> this MR.

Done: https://code.launchpad.net/~intrigeri/apparmor/glib-schemas/+merge/326655

So I think this MR can be rejected.

review: Disapprove
Revision history for this message
Steve Beattie (sbeattie) wrote :

This wasn't really rejected, just superceded by intregeri's merge proposal above, which was accepted and merged.

Thanks for working on this!

Unmerged revisions

3111. By Cameron Norman

abstractions/gnome: allow reading gschemas, gtk3 per-user config

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches