Ubuntu
wslu package

Merge ~callmepk/ubuntu/+source/wslu:ubuntu/master into ~ubuntu-core-dev/ubuntu/+source/wslu:ubuntu/master

  1. Git
  2. lp:~callmepk/ubuntu/+source/wslu
  3. ubuntu/master
  4. Merge into ubuntu/master
Proposed by Patrick Wu
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: ~callmepk/ubuntu/+source/wslu:ubuntu/master
Merge into: ~ubuntu-core-dev/ubuntu/+source/wslu:ubuntu/master
Diff against target: 188 lines (+121/-3)
8 files modified
debian/changelog (+8/-0)
debian/compat (+1/-1)
debian/control (+1/-1)
debian/patches/0011-src-wslu-header-reg.exe-path-not-properly-set.patch (+22/-0)
debian/patches/0012-src-wslfetch.sh-update-Ubuntu-logo.patch (+57/-0)
debian/patches/0013-src-wslu-header-fix-an-issue-that-Ubuntu-will-not-be.patch (+22/-0)
debian/patches/series (+3/-0)
debian/rules (+7/-1)
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Information
Review via email: mp+386311@code.staging.launchpad.net

Commit message

Quick update to solve build failure on proposed due to the changes related to inkscape on groovy

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Patrick, hardcoding the version in debian/rules like that means it's going to fail to build again when H-serie opens, could you figure out a way to resolve that problem? If we only plan to target a few stable serie it could make sense to check if the build is for any of those instead?

review: Needs Fixing
Revision history for this message
Patrick Wu (callmepk) wrote :

Just did the fix as requested. Right now I am using the method to check the version of inkscape. Also I have to fallback compat since for some reason xenial build system is using debhelper version 9.

Revision history for this message
Sebastien Bacher (seb128) wrote :

sorry but I'm not sure to understand why you lowered the the debhelper compat version, why is it only an issue now and was not one in the previous upload?
also could you document the new changes to the compat and rules in the changelog?

review: Needs Information
Revision history for this message
Patrick Wu (callmepk) wrote :

So what happens is that xenial build failed on PPA which complains it requires debhelper 9 to get it build, which required me to fallback. I will also try to document the changes in changelog.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Sorry Patrick, it's getting a bit complicated

I've uploaded to G-serie the debian/rules syntax change to fix the build, and I've pushed the commits without the recent changes to git for now

0ubuntu2 has also been uploaded to focal now, other series are on older versions so they are going to need some backport to those series anyway right? so we can work next on xenial and bionic

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches