Capomastro

Merge lp://staging/~caio1982/capomastro/missing-default-archiver-1419708 into lp://staging/capomastro

missing-default-archiver-1419708
Merge into trunk

Proposed by Caio Begotti on 2015-03-05

Status:

Merged

Approved by:

Daniel Manrique on 2015-03-05

Approved revision:

162

Merged at revision:

160

Proposed branch:

lp://staging/~caio1982/capomastro/missing-default-archiver-1419708

Merge into:

lp://staging/capomastro

Diff against target:

65 lines (+29/-0)

3 files modified

debian/changelog (+6/-0)
projects/tests/test_views.py (+10/-0)
projects/views.py (+13/-0)

To merge this branch:

bzr merge lp://staging/~caio1982/capomastro/missing-default-archiver-1419708

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2015-03-05	Approve on 2015-03-05
Review via email: mp+251939@code.staging.launchpad.net

Description of the change

This MR should fix https://bugs.launchpad.net/capomastro/+bug/1419708 as we already had some default archiver tests in Capomastro (to check both for failing scenarios and working ones) but we were still missing some, added here, as well fixing the missing context data in the project update view.

lp://staging/~caio1982/capomastro/missing-default-archiver-1419708 updated on 2015-03-05

162. By Caio Begotti on 2015-03-05: update the debian changelog with the fix

Revision history for this message

Daniel Manrique (roadmr) wrote on 2015-03-05:

I wonder if this will conflict with the first three commits in swift-archiver merge request. Let me know if you'd like me to split that out into a separate branch; I concede that swift-archiver grew larger than anticipated. I'm talking about these three:

164. archives/models: Ensure at save-time that only one Archive is set as default.

Essentially if the current one is set to be default, we take care of
unsetting any others before saving this one.
163. By Daniel Manrique on 2015-02-25

archives/models: Add failing test for having only one default archive set.
162. By Daniel Manrique on 2015-02-25

archives/models: Small tweak to __str__ to show default boolean value

This was useful for debugging.

Anyway, your changes are OK and you were here first, so approving.

review: Approve