Merge lp://staging/~caio1982/capomastro/depstatus-1421337 into lp://staging/capomastro
Proposed by
Caio Begotti
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 209 |
| Merged at revision: | 201 |
| Proposed branch: | lp://staging/~caio1982/capomastro/depstatus-1421337 |
| Merge into: | lp://staging/capomastro |
| Diff against target: |
138 lines (+29/-15) 6 files modified
capomastro/site/templatetags/capomastro_bootstrap.py (+7/-1) capomastro/site/templatetags/tests/test_capomastro_bootstrap.py (+3/-2) jenkins/models.py (+2/-1) jenkins/tests/test_views.py (+1/-1) projects/tests/test_views.py (+5/-4) projects/views.py (+11/-6) |
| To merge this branch: | bzr merge lp://staging/~caio1982/capomastro/depstatus-1421337 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Improve how direct dependencies builds have their status shown in the detail view.
Description of the change
Address the problems of https:/
The original bug ticket has a screenshot showing the before and after these changes.
Some tests got changed because of the new default status for dependencies and because, well, we're not using the notifications bubbles texts in the tests anymore.
I have only tested these changes locally, not on Wendigo because PS4.5 is a bit overloaded now.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me, the "building" status is quite clear and less likely to get lost than the bubble.