Merge lp://staging/~c.groner/pantheon-terminal/fix-1169255 into lp://staging/~elementary-apps/pantheon-terminal/trunk
Proposed by
Carl Groner
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Adam Bieńkowski | ||||
| Approved revision: | 954 | ||||
| Merged at revision: | 954 | ||||
| Proposed branch: | lp://staging/~c.groner/pantheon-terminal/fix-1169255 | ||||
| Merge into: | lp://staging/~elementary-apps/pantheon-terminal/trunk | ||||
| Diff against target: |
74 lines (+29/-24) 2 files modified
src/PantheonTerminalWindow.vala (+1/-1) src/TerminalWidget.vala (+28/-23) |
||||
| To merge this branch: | bzr merge lp://staging/~c.groner/pantheon-terminal/fix-1169255 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Bieńkowski (community) | code / testing | Approve | |
|
Review via email:
|
|||
Commit message
* Fix links not being selectable for copying.
Description of the change
Allow selection of all or part of a link for copying & pasting.
The current default behavior will instantly open the link, not allowing a link/url to be selected for copying (as noted in bug 1169255). My proposed solution opens the link on the mouse release event only if a selection was not made.
To post a comment you must log in.
Revision history for this message
| Adam Bieńkowski (donadigo) wrote | # |
review:
Approve
(code / testing)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It looks good. Thanks for your contribution!