qtcreator-plugin-ubuntu

Merge lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator into lp://staging/qtcreator-plugin-ubuntu

rebase_to_ubuntu-emulator
Merge into trunk

Proposed by Zoltan Balogh on 2014-02-05

Status:	Merged
Approved by:	Zoltan Balogh on 2014-02-11
Approved revision:	87
Merged at revision:	86
Proposed branch:	lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator
Merge into:	lp://staging/qtcreator-plugin-ubuntu
Diff against target:	197 lines (+23/-44) 6 files modified share/qtcreator/ubuntu/scripts/local_create_emulator (+2/-6) share/qtcreator/ubuntu/scripts/local_search_images (+1/-2) share/qtcreator/ubuntu/scripts/local_start_emulator (+2/-3) src/ubuntu/ubuntuconstants.h (+4/-2) src/ubuntu/ubuntudeviceswidget.cpp (+12/-12) src/ubuntu/ubuntudeviceswidget.ui (+2/-19)
To merge this branch:	bzr merge lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Sergio Schvezov (community)		2014-02-06	Approve on 2014-02-11
PS Jenkins bot	continuous-integration		Approve on 2014-02-11
Benjamin Zeller		2014-02-05	Approve on 2014-02-07
Alan Pope 🍺🐧🐱 🦄		2014-02-07	Pending
Review via email: mp+204954@code.staging.launchpad.net

Commit message

Emulator features based on ubuntu-emulator

Description of the change

Emulator features based on ubuntu-emulator

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-05:

PASSED: Continuous integration, rev:80
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/123/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-amd64-ci/54
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-armhf-ci/54

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/123/rebuild

review: Approve (continuous-integration)

lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator updated on 2014-02-05

81. By Zoltan Balogh on 2014-02-05: Emulator features based on ubuntu-emulator

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-05:

PASSED: Continuous integration, rev:81
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/125/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-amd64-ci/56
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-armhf-ci/56

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/125/rebuild

review: Approve (continuous-integration)

lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator updated on 2014-02-06

82. By Zoltan Balogh on 2014-02-06: fix the HOME variable for pkexec

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-06:

PASSED: Continuous integration, rev:82
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/127/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-amd64-ci/58
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-armhf-ci/58

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/127/rebuild

review: Approve (continuous-integration)

Revision history for this message

Benjamin Zeller (zeller-benjamin) wrote on 2014-02-07:

- For me the emulator is created with the wrong owner and does not show up in creator until i chown -R the emulator
directory

- starting the emulator while another one is created seems to stop the creation script, but the UI still looks like
the emulator script is still running

- UI does not adapt if the create emulator script fails, should be the same problem as the previous point

review: Needs Fixing

lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator updated on 2014-02-07

83. By Zoltan Balogh on 2014-02-07: Fix the ownership of the created emulator

Revision history for this message

Benjamin Zeller (zeller-benjamin) wrote on 2014-02-07:

Works for me, ready to go

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-07:

PASSED: Continuous integration, rev:83
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/129/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-amd64-ci/60
SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-trusty-armhf-ci/60

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/129/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-02-10:

Why not use ubuntu-emulator list?

review: Needs Information

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-02-10:

55 +const char DEFAULT_EMULATOR_PATH[] = ".local/share/ubuntu-emulator";

How about using $XDG_DATA_HOME/ubuntu-emulator ?

review: Needs Fixing

Revision history for this message

Zoltan Balogh (bzoltan) wrote on 2014-02-10:

> 28 +find ~/.local/share/ubuntu-emulator/ -name "*img" 2>/dev/null |sed -e
> "s/^$.*ubuntu-emulator\/.*$\/.*$/\1/"|sort|uniq|xargs stat --format="%n %y"
> 2>&1|egrep -v "missing operand|for more information"|sed -e 's/^.*ubuntu-
> emulator\/$.*$ $[0-9]*-[0-9]*-[0-9]* [0-9]*:[0-9]*:[0-9]*$\..*$/\1 \2/'
>
> Why not use ubuntu-emulator list?

Good point. I was not aware of this feature when I made this script.

Actually the ubuntu-emulator list does not return exactly the same output as this oneliner. I would happily use the ubuntu-emulator list, if it is a stable tool and the output is not changed in the future without sending a patch against the IDE.

Revision history for this message

Zoltan Balogh (bzoltan) wrote on 2014-02-10:

> 55 +const char DEFAULT_EMULATOR_PATH[] = ".local/share/ubuntu-emulator";
>
> How about using $XDG_DATA_HOME/ubuntu-emulator ?

Since the pkexec ate my $HOME I trust nothing :)

I test if this $XDG_DATA_HOME is reliable and will use it.

lp://staging/~bzoltan/qtcreator-plugin-ubuntu/rebase_to_ubuntu-emulator updated on 2014-02-10