Merge lp://staging/~bzoltan/qtcreator-plugin-ubuntu/Fixes_LP1495062 into lp://staging/qtcreator-plugin-ubuntu

Proposed by Zoltan Balogh
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 418
Merged at revision: 424
Proposed branch: lp://staging/~bzoltan/qtcreator-plugin-ubuntu/Fixes_LP1495062
Merge into: lp://staging/qtcreator-plugin-ubuntu
Diff against target: 61 lines (+5/-5)
5 files modified
share/qtcreator/templates/wizards/ubuntu/backend-app-cmake/CMakeLists.txt (+1/-1)
share/qtcreator/templates/wizards/ubuntu/backend-app-qmake/appName/appName.desktop (+1/-1)
share/qtcreator/templates/wizards/ubuntu/simple-app-qmake/appName/appName.desktop (+1/-1)
share/qtcreator/templates/wizards/ubuntu/simple-app-qmlproject/displayName.desktop (+1/-1)
share/qtcreator/templates/wizards/ubuntu/simple-i18n-cmake/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp://staging/~bzoltan/qtcreator-plugin-ubuntu/Fixes_LP1495062
Reviewer Review Type Date Requested Status
Benjamin Zeller Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+270884@code.staging.launchpad.net

Commit message

Change exec line in desktop files. Fixes LP: #1495062

Description of the change

Change exec line in desktop files. Fixes LP: #1495062

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

You forgot the cmake projects:

./simple-i18n-cmake/CMakeLists.txt:set(EXEC "qmlscene $@ ${%ProjectName:u%_DIR}/${MAIN_QML}")
./backend-app-cmake/CMakeLists.txt:set(EXEC "qmlscene $@ ${%ProjectName:u%_DIR}/${MAIN_QML}")

review: Needs Fixing
418. By Zoltan Balogh

cmake projects too

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: