Merge lp://staging/~bryce2/fatrace/filter_option into lp://staging/fatrace

Proposed by Bryce Nesbitt
Status: Merged
Merged at revision: 62
Proposed branch: lp://staging/~bryce2/fatrace/filter_option
Merge into: lp://staging/fatrace
Diff against target: 94 lines (+36/-1)
1 file modified
fatrace.c (+36/-1)
To merge this branch: bzr merge lp://staging/~bryce2/fatrace/filter_option
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Bryce Nesbitt (community) Needs Resubmitting
Review via email: mp+251697@code.staging.launchpad.net

Description of the change

New option:

-f MASK, --filter Show only the given event types (choose from C,R,O or W)

I use "-f W" to monitor writes, of which Google Chrome seems to be by far the worst culprit, especially if any tab has ever opened Youtube!

To post a comment you must log in.
64. By Bryce Nesbitt <email address hidden>

Fix no flag case

Revision history for this message
Martin Pitt (pitti) wrote :

Very nice, thanks for this! I just see some minor issues below. I'll merge this once these get fixed.

review: Needs Fixing
65. By Bryce Nesbitt <email address hidden>

fix a few style issues
make --filter case insensitive

Revision history for this message
Bryce Nesbitt (bryce2) wrote :

bzr commit
modified fatrace.c
Committed revision 65.

bzr push
Pushed up to revision 65.

review: Needs Resubmitting
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I added an error message for unknown options, documented the new version in the manpage, and fixed some style issues. I did a new upstream release https://launchpad.net/fatrace/trunk/0.10 with this, and will package this for Debian unstable now (from where it will flow into the next Ubuntu development series).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches