Merge ~bryce/ubuntu/+source/virglrenderer:merge-v0.10.4-1-lunar into ubuntu/+source/virglrenderer:debian/sid

Old delta mapped to commits:
673f4d0c1 -> 0.10.0
95e581fd1 -> 0.10.0
b05bb61f4 -> 0.10.0

yep, all changes seem applied upstream and therefore this can be a sync.

However, while it looks good here, this recent update
- https://bugs.launchpad.net/ubuntu/+source/virglrenderer/+bug/1993453/comments/2
- https://salsa.debian.org/debian/virglrenderer/-/merge_requests/5
suggests otherwise

But having HW accel there would actually be great, we do not have the skill to support such graphic heavy things for the serve rteam. But it was mentioned it was in main before, maybe the former owning team is willing to continue owning it?
Please dig who that was and ask them.

On Fri, Jan 06, 2023 at 07:03:01AM -0000, Christian Ehrhardt  wrote:
> However, while it looks good here, this recent update
> - https://bugs.launchpad.net/ubuntu/+source/virglrenderer/+bug/1993453/comments/2
> - https://salsa.debian.org/debian/virglrenderer/-/merge_requests/5
> suggests otherwise
>
> But having HW accel there would actually be great, we do not have the skill to support such graphic heavy things for the serve rteam. But it was mentioned it was in main before, maybe the former owning team is willing to continue owning it?
> Please dig who that was and ask them.
> --
> https://code.launchpad.net/~bryce/ubuntu/+source/virglrenderer/+git/virglrenderer/+merge/435207
> You are the owner of ~bryce/ubuntu/+source/virglrenderer:merge-v0.10.4-1-lunar.

Thanks for the review Christian.

The video acceleration functionality is new in 0.10, so since we
currently carry 0.9, it's not a regression if we use Jeremy's changes to
drop, it at least for the near term while bugs are shaking out in
testing.

libva left main way back in Trusty, and is related part to the
X.org/Wayland stack. I don't think there was really an "owning team"
for it back then, but since it interfaces between desktop and
kernel/graphics it could fall under either team. I can reach out to
Timo Aaltonen who may be better able to advise.

Timo and Jeremy confirmed there does not seem to be any activity around getting libva into main, just a general desire, and it's not clear what team would champion a MIR. Given that server team isn't the right owner for it, I think we should leave it disabled until others take initiative on it. If it becomes requested by our users we can revisit.

Thanks Bryce, and sorry for the back and forth that was needed here.
I've planned a candidate that we can revisit for 23.10 and until then can check opinions/responsibilities in further discussion. For this merge it should be ok as-is now.

Except that you currently have an empty 0.10.4-1ubuntu2 on top which is wrong.
Furthermore following the usual "change done on merge" style I'd expect "* d/rules: Disable video acceleration on Ubuntu until libva gets repromoted." as

* Added changes:
  - d/rules: Disable video acceleration on Ubuntu until libva gets repromoted.

Once you resolved those two I'd be +1, so consider uploading unless there is more.

Thanks, branch updated with those changes, and package uploaded to lunar:

Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/virglrenderer
Vcs-Git-Commit: b2faf6dfaf9dc1f963fa53aa9d6c4f48e0f803ca
Vcs-Git-Ref: refs/heads/merge-v0.10.4-1-lunar

$ dput ubuntu ../virglrenderer_0.10.4-1ubuntu1_source.changes
D: Setting host argument.
Checking signature on .changes
Checking signature on .dsc
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading virglrenderer_0.10.4-1ubuntu1.dsc: done.
  Uploading virglrenderer_0.10.4.orig.tar.bz2: done.
  Uploading virglrenderer_0.10.4-1ubuntu1.debian.tar.xz: done.
  Uploading virglrenderer_0.10.4-1ubuntu1_source.buildinfo: done.
  Uploading virglrenderer_0.10.4-1ubuntu1_source.changes: done.
Successfully uploaded packages.