Ubuntu
sudo package

Merge ~bryce/ubuntu/+source/sudo:ubuntu/focal-devel into ubuntu/+source/sudo:ubuntu/focal-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/sudo
  3. ubuntu/focal-devel
  4. Merge into ubuntu/focal-devel
Proposed by Bryce Harrington
Status: Approved
Approved by: Bryce Harrington
Approved revision: 17c60860104d2fac1de9ce6c418d95eabca84688
Proposed branch: ~bryce/ubuntu/+source/sudo:ubuntu/focal-devel
Merge into: ubuntu/+source/sudo:ubuntu/focal-devel
Diff against target: 91 lines (+69/-0)
3 files modified
debian/changelog (+11/-0)
debian/patches/ignore-rlimit-core-failure.patch (+57/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+387483@code.staging.launchpad.net

Description of the change

Quells an unnecessary warning when running sudo in a focal lxc container. Fix comes from upstream; I trimmed some debug messaging to get a minimal fix.

SRU: https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/1857036
PPA: https://launchpad.net/~bryce/+archive/ubuntu/sudo-sru-lp1857036-setrlimit-in-lxc

Test Case:

$ lxc launch ubuntu:20.04/amd64 sudo-sru-lp1857036-test
$ lxc shell sudo-sru-lp1857036-test

# sudo --login --user ubuntu
sudo: setrlimit(RLIMIT_CORE): Operation not permitted
To run a command as administrator (user "root"), use "sudo <command>".
See "man sudo_root" for details.
$ logout

Install the PPA
# apt-add-repository -yus ppa:bryce/sudo-sru-lp1857036-setrlimit-in-lxc
# apt-get install sudo

# sudo --login --user ubuntu
$

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I can review this tomorrow morning.

Reply
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Alright, I verified that it works:

root@sudo-sru-lp1857036-test:~# sudo --login --user ubuntu
sudo: setrlimit(RLIMIT_CORE): Operation not permitted
To run a command as administrator (user "root"), use "sudo <command>".
See "man sudo_root" for details.

ubuntu@sudo-sru-lp1857036-test:~$

versus:

root@sudo-sru-lp1857036-test:~# sudo --login --user ubuntu
To run a command as administrator (user "root"), use "sudo <command>".
See "man sudo_root" for details.

ubuntu@sudo-sru-lp1857036-test:~$

Reply
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

The patch looks great. I just noticed a small nit on the changelog entry, but otherwise this LGTM. I'm marking as Approved. Thanks!

review: Approve
Reply
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, I've added the suggestion for the changelog entry, and uploaded.

$ git ubuntu tag --upload
$ git push pkg upload/1.8.31-1ubuntu1.1
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 12 threads
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 2.49 KiB | 424.00 KiB/s, done.
Total 11 (delta 7), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/sudo
 * [new tag] upload/1.8.31-1ubuntu1.1 -> upload/1.8.31-1ubuntu1.1
$ dput ubuntu ${changes_file}
Checking signature on .changes
gpg: /home/bryce/pkg/Sudo/sru-lp1857036-setrlimit-in-lxc/sudo_1.8.31-1ubuntu1.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/Sudo/sru-lp1857036-setrlimit-in-lxc/sudo_1.8.31-1ubuntu1.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading sudo_1.8.31-1ubuntu1.1.dsc: done.
  Uploading sudo_1.8.31-1ubuntu1.1.debian.tar.xz: done.
  Uploading sudo_1.8.31-1ubuntu1.1_source.buildinfo: done.
  Uploading sudo_1.8.31-1ubuntu1.1_source.changes: done.
Successfully uploaded packages.

Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches