Merge ~bryce/ubuntu/+source/resource-agents:ubuntu/focal-devel into ubuntu/+source/resource-agents:ubuntu/focal

Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: bd339eea955c322f9fae388ea0c8787f65c36500
Merge reported by: Bryce Harrington
Merged at revision: bd339eea955c322f9fae388ea0c8787f65c36500
Proposed branch: ~bryce/ubuntu/+source/resource-agents:ubuntu/focal-devel
Merge into: ubuntu/+source/resource-agents:ubuntu/focal
Diff against target: 79 lines (+57/-0)
3 files modified
debian/changelog (+11/-0)
debian/patches/crm-mon-format.patch (+45/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Canonical Server Pending
Canonical Server Core Reviewers Pending
Canonical Server packageset reviewers Pending
Review via email: mp+392346@code.staging.launchpad.net

Description of the change

Backport of an upstream fix for a cpe-foundation escalated bug.

I've confirmed the fix is included in the groovy version of resource-agents, although the fix is a bit different there in that it relies on XML rather than raw text parsing. So, while the focus is the focal SRU, it probably wouldn't hurt to also check that groovy's resource-agent works properly with the test case.

The commit didn't have an upstream bug report associated with it. I skimmed recently closed bug reports but didn't spot one; #1527 sounded close but actually covers a different issue.

PPA: https://launchpad.net/~bryce/+archive/ubuntu/resource-agents-sru-lp1900016-crm-mon-format
Bug: https://bugs.launchpad.net/ubuntu/groovy/+source/resource-agents/+bug/1900016

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for this Bryce. The packaging changes look good, I am going to try to reproduce the issue to confirm it is indeed fixed with this upstream patch (also update the Test Case section in the SRU bug description).

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Bryce I did some back and forth with the field engineer and I added a test case to the bug description. Hopefully it will be enough to the SRU.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, tagged, pushed and uploaded:

$ git push pkg upload/1%4.5.0-2ubuntu2.1
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 12 threads
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 2.37 KiB | 303.00 KiB/s, done.
Total 11 (delta 7), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/resource-agents
 * [new tag] upload/1%4.5.0-2ubuntu2.1 -> upload/1%4.5.0-2ubuntu2.1

$ dput ubuntu resource-agents_4.5.0-2ubuntu2.1_source.changes
Checking signature on .changes
gpg: /home/bryce/pkg/ResourceAgents/sru-lp1900016-crm-mon-format/resource-agents_4.5.0-2ubuntu2.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/ResourceAgents/sru-lp1900016-crm-mon-format/resource-agents_4.5.0-2ubuntu2.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading resource-agents_4.5.0-2ubuntu2.1.dsc: done.
  Uploading resource-agents_4.5.0-2ubuntu2.1.debian.tar.xz: done.
  Uploading resource-agents_4.5.0-2ubuntu2.1_source.buildinfo: done.
  Uploading resource-agents_4.5.0-2ubuntu2.1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

This has migrated

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches