Merge ~bryce/ubuntu/+source/php7.4:fix-lp1865218-mod-php-upgrade-groovy into ubuntu/+source/php7.4:ubuntu/devel
Proposed by
Bryce Harrington
Status: | Merged |
---|---|
Approved by: | Bryce Harrington |
Approved revision: | 119afc2448d751608bc3045cc03ff4f971dc1629 |
Merge reported by: | Bryce Harrington |
Merged at revision: | 119afc2448d751608bc3045cc03ff4f971dc1629 |
Proposed branch: | ~bryce/ubuntu/+source/php7.4:fix-lp1865218-mod-php-upgrade-groovy |
Merge into: | ubuntu/+source/php7.4:ubuntu/devel |
Diff against target: |
38 lines (+16/-3) 2 files modified
debian/changelog (+8/-0) debian/libapache2-mod-php.postinst.extra (+8/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+383848@code.staging.launchpad.net |
Description of the change
SRU to fix failure when upgrading with mod-php enabled.
I've verified this works using the test case from the bug #1865218, using this PPA:
PPA: https:/
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Generally I like the new approach, to disable the old one to avoid the latter conflict.
By not existing early the new one would be enabled as intended.
A few questions:
Improved wording
"Disabling $PHP_MODULE" -> "Disabling old $PHP_MODULE"
If you insist on being perfect since this would also trigger on downgrades you can version-compare and say "old/new" but downgrades are nonono anyway, so a static "old" will do as well.
"failed to enable $PHP_MODULE"
That should now better be something like:
"failed to disable old $PHP_MODULE module"
In some of the SRUs backports the php version in the message needs to change at "favor of using PHP 7.4".
If you want you might use @PHP_VERSION@ to get code that is the same for all releases.