Ubuntu
node-nan package

Merge ~bryce/ubuntu/+source/node-nan:merge-v2.16.0-1-kinetic into ubuntu/+source/node-nan:debian/sid

  1. Git
  2. lp:~bryce/ubuntu/+source/node-nan
  3. merge-v2.16.0-1-kinetic
  4. Merge into debian/sid
Proposed by Bryce Harrington
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Bryce Harrington
Merged at revision: dbb7c30101182f46bc8d8981f7e4455cf30ff2d4
Proposed branch: ~bryce/ubuntu/+source/node-nan:merge-v2.16.0-1-kinetic
Merge into: ubuntu/+source/node-nan:debian/sid
Diff against target: 94 lines (+55/-1)
4 files modified
debian/changelog (+17/-0)
debian/control (+2/-1)
debian/patches/disable-test-for-s390x.patch (+35/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Sergio Durigan Junior (community) Approve
Canonical Server Reporter Pending
Review via email: mp+428824@code.staging.launchpad.net

Description of the change

Simple merge from upstream. I kind of wonder if this could be a sync - I tried building the debian package in a PPA with s390x enabled but it only built for amd64:

    https://launchpad.net/~bryce/+archive/ubuntu/node-nan-merge-v2.16.0-1/+packages

However looking at the git log there's just one change of substance, which doesn't relate to the test problem (just enables Node 18). The delta has been forwarded upstream, but no response yet. So it seems doubtful the test is fixed yet, and the delta should remain for now.

The Node 18 support is probably important for kinetic, though, as it appears nodejs 18 is in -proposed:

 nodejs | 12.22.9~dfsg-1ubuntu3 | jammy/universe
 nodejs | 16.14.2+dfsg1-1ubuntu3 | kinetic/universe
 nodejs | 18.6.0+dfsg-3ubuntu1 | kinetic-proposed/universe

PPA: https://launchpad.net/~bryce/+archive/ubuntu/node-nan-merge-v2.16.0-1/+packages

$ lp-test-ppa ppa:bryce/node-nan-merge-v2.16.0-1 --release kinetic

stirling: ~$ lp-test-ppa ppa:bryce/node-nan-merge-v2.16.0-1 --release kinetic
Tests for PPA node-nan-merge-v2.16.0-1
---- ---- ---- ----
Release: kinetic
Sources:
  SRC: node-nan @ 2.16.0-1ubuntu1~kinetic1 - Published
Triggers on published Sources:
              node-nan @ amd64 for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @amd64 ♻️ Trigger all proposed @{arch} ♻️ 💍
              node-nan @ s390x for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @s390x ♻️ Trigger all proposed @{arch} ♻️ 💍
              node-nan @ ppc64el for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @ppc64el ♻️ Trigger all proposed @{arch} ♻️ 💍
              node-nan @ arm64 for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @arm64 ♻️ Trigger all proposed @{arch} ♻️ 💍
              node-nan @ armhf for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @armhf ♻️ Trigger all proposed @{arch} ♻️ 💍
              node-nan @ riscv64 for node-nan/2.16.0-1ubuntu1~kinetic1 Trigger @riscv64 ♻️ Trigger all proposed @{arch} ♻️ 💍
Results: (from http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-node-nan-merge-v2.16.0-1/?format=plain)
  node-nan @ amd64:
    23.08.22 22:14:25 Log 🗒️ ✅ Triggers: node-nan/2.16.0-1ubuntu1~kinetic1
  node-nan @ armhf:
    23.08.22 22:04:56 Log 🗒️ ✅ Triggers: node-nan/2.16.0-1ubuntu1~kinetic1
  node-nan @ ppc64el:
    23.08.22 22:04:06 Log 🗒️ ✅ Triggers: node-nan/2.16.0-1ubuntu1~kinetic1
  node-nan @ s390x:
    23.08.22 22:03:47 Log 🗒️ ✅ Triggers: node-nan/2.16.0-1ubuntu1~kinetic1
Running:
    time pkg release arch ppa trigger
    2423 node-nan kinetic arm64 bryce/node-nan-merge-v2.16.0-1 node-nan/2.16.0-1ubuntu1~kinetic1
Waiting: (none)

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I will take a look at this one.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Bryce.

The package is "Architecture: all", so it won't build on non-amd64 architectures. The problem fixed by the patch doesn't seem to be fixed indeed; Debian is also affected by it, and we can see that the test is still failing there:

https://ci.debian.net/data/autopkgtest/unstable/s390x/n/node-nan/24616299/log.gz

Therefore, I agree that the delta should be kept.

BTW, this also means that it may be a good idea to send the patch to Debian and have the package become a sync.

Otherwise, LGTM. +1

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: bryce, sergiodj
Uploaders: bryce, sergiodj
MP auto-approved

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

This has migrated

$ rmad node-nan
 node-nan | 2.15.0-1ubuntu1 | jammy/universe
 node-nan | 2.16.0-1ubuntu1 | kinetic/universe

node-nan | 2.14.2-2 | stable
node-nan | 2.16.0-1 | testing
node-nan | 2.16.0-1 | unstable

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches