Ubuntu
nmap package

Merge ~bryce/ubuntu/+source/nmap:sru-lp1908223-focal into ubuntu/+source/nmap:ubuntu/focal-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/nmap
  3. sru-lp1908223-focal
  4. Merge into ubuntu/focal-devel
Proposed by Bryce Harrington
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Bryce Harrington
Merged at revision: 8f66656ff67b64e6925d93e22a8498b8d80ba4f5
Proposed branch: ~bryce/ubuntu/+source/nmap:sru-lp1908223-focal
Merge into: ubuntu/+source/nmap:ubuntu/focal-devel
Diff against target: 83 lines (+49/-1)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/avoid-assertion-failure-when-unsolicited-arp-response-received.patch (+38/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Athos Ribeiro (community) Approve
Canonical Server Reporter Pending
Canonical Server Core Reviewers Pending
Canonical Server Pending
Review via email: mp+437076@code.staging.launchpad.net

Description of the change

SRUs a patch to fix an assertion crash that none of us seem to be able to reproduce but several community members have. The reporter indicates running it in a loop several hundred times might trigger it; I haven't attempted that but might be worth a try. In any case, we're going to rely on the community to perform the testing.

The patch itself is just a couple code lines, that only stops the clock when it's running. That seems straightforward and unlikely to lead to regression. Please doublecheck that my SRU text in the bug report makes sense.

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Although I could not reproduce the issue, the patch is short and simple, and the SRU text makes sense (in special the test plan). The package builds fine. Unfortunately, there are no dep8 tests for the package.

LGTM. Thanks, Bryce!

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: bryce, athos-ribeiro
Uploaders: bryce, athos-ribeiro
MP auto-approved

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks,

Successfully signed dsc, buildinfo, changes files
Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/nmap
Vcs-Git-Commit: 8f66656ff67b64e6925d93e22a8498b8d80ba4f5
Vcs-Git-Ref: refs/heads/sru-lp1908223-focal
$ dput ubuntu ../nmap_7.80+dfsg1-2ubuntu0.1_source.changes
gpg: ../nmap_7.80+dfsg1-2ubuntu0.1_source.changes: Valid signature from E603B2578FB8F0FB
gpg: ../nmap_7.80+dfsg1-2ubuntu0.1.dsc: Valid signature from E603B2578FB8F0FB
Checking signature on .changes
Checking signature on .dsc
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading nmap_7.80+dfsg1-2ubuntu0.1.dsc: done.
  Uploading nmap_7.80+dfsg1-2ubuntu0.1.debian.tar.xz: done.
  Uploading nmap_7.80+dfsg1-2ubuntu0.1_source.buildinfo: done.
  Uploading nmap_7.80+dfsg1-2ubuntu0.1_source.changes: done.
Successfully uploaded packages.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches