Ubuntu
nginx package

Merge ~bryce/ubuntu/+source/nginx:merge-v1.22.0-1-kinetic into ubuntu/+source/nginx:ubuntu/devel

  1. Git
  2. lp:~bryce/ubuntu/+source/nginx
  3. merge-v1.22.0-1-kinetic
  4. Merge into ubuntu/devel
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 85684fad836080922d74619f82ec0a57f6a41229
Proposed branch: ~bryce/ubuntu/+source/nginx:merge-v1.22.0-1-kinetic
Merge into: ubuntu/+source/nginx:ubuntu/devel
Diff against target: 34 lines (+7/-3)
2 files modified
debian/changelog (+7/-0)
debian/control (+0/-3)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Needs Information
Canonical Server Reporter Pending
git-ubuntu import Pending
Review via email: mp+428193@code.staging.launchpad.net

Description of the change

nginx 1.22.0 introduces a new binary, nginx-dev, into the main archive. This pulls in various dependencies, including three items from universe. This causes a migration failure.

Since nginx-dev is new, no risk of regression. I considered instead of dropping the packages, making them Suggests, however looking at how dovecot and apache handle their -dev packages it seems more typical to just drop the problematic universe packages. Appreciate other opinions on this though.

quilt has been in universe since xenial at least, and I don't think any -dev packages include it, so I wonder if Debian could drop that too. The other two packages probably go along with other parts of our delta, so would stay on our end.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi Bryce,

1. quilt would not end up in the final dependencies I guess - would it?
   If not it is fine to keep it around at build time.
   The other two libgd-dev and libgeoip-dev make sense

2. nginx-dev since nothing is depending on it, there is some magic
   Any package that is -dev, -doc, ... of a source in main is also included
   automatically into main.
   That often works fine, but if it causes trouble - for example due
   to dependencies - you can exclude it via
   https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu/tree/supported#n112
   That would be independent to this merge.

I feel I struggle to explain, is that sufficient to go forward?

review: Needs Information
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I see on excuses, it really might be only nginx-dev that triggers this
  nginx-dev/amd64 in main cannot depend on libgd-dev in universe
  nginx-dev/amd64 in main cannot depend on libgeoip-dev in universe
  nginx-dev/amd64 in main cannot depend on quilt in universe

The binaries of nginx using this are already in universe.
So yeah in this case just land the change for #2 (no package upload) and you should be good.

The proposed change would drop actual features which we do not need to do AFAICS atm.

Once landed we can move nginx-dev to universe in kinetic-proposed and it should migrate.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, looks like Lucasz took care of adding nginx-dev

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches