Merge ~bryce/ubuntu/+source/monitoring-plugins:monitoring-plugins-sru-lp1827159-focal into ubuntu/+source/monitoring-plugins:ubuntu/focal-devel

Proposed by Bryce Harrington
Status: Superseded
Proposed branch: ~bryce/ubuntu/+source/monitoring-plugins:monitoring-plugins-sru-lp1827159-focal
Merge into: ubuntu/+source/monitoring-plugins:ubuntu/focal-devel
Diff against target: 78 lines (+44/-1)
4 files modified
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/patches/exclude-tmpfs-squashfs-tracefs.patch (+30/-0)
debian/patches/series (+3/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt (community) Needs Fixing
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+375358@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2019-11-14.

Description of the change

This is a fix for https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1827159

A PPA with the proposed fix is available at:

  https://launchpad.net/~bryce/+archive/ubuntu/monitoring-plugins-sru-lp1827159

Test case:
$ lxc create ubuntu-daily:20.04/amd64 lp1827159
$ lxc exec lp1827159 bash
# apt-get -y update
# apt-get install monitoring-plugins
# snap install gnome-calculator
[...]
# /usr/lib/nagios/plugins/check_disk -w 10 -c 10
--> FAILS

# add-apt-repository -y ppa:bryce/monitoring-plugins-sru-lp1827159
# apt-get -y update
# apt-get -y install monitoring-plugins
# /usr/lib/nagios/plugins/check_disk -w 10 -c 10
--> PASS

More test case examples are available in the bug report

This fix targets focal-only, but the issue also exists in stable releases so I'm leaving open the potential of SRUing this, once it's proven sufficiently regression-free in the development release.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

Ack to the fix as a fix to the reported problem.
But I'd ask to bring it upstream or to Debian (or if it is from upstream reference the source).

So I'd expect in the bug header either:
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=<todo-bug
or
Forwarded: yes + a hint where
or
Origin: upstream, <todo-URL-to-git>

Otherwise we will revisit it in years from now and wonder why it still is a package with Delta.
Therefore it would be great to trigger at least one of the paths above and then I'd think it is ready for upload.

Note: misleading branch name -sru- while being for focal :-)

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches