Ubuntu
mako package

Merge ~bryce/ubuntu/+source/mako:fix-lp1990446-kinetic into ubuntu/+source/mako:ubuntu/kinetic-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/mako
  3. fix-lp1990446-kinetic
  4. Merge into ubuntu/kinetic-devel
Proposed by Bryce Harrington
Status: Merged
Merged at revision: e2dc97ad61463c963281089750c71305cc9a6d56
Proposed branch: ~bryce/ubuntu/+source/mako:fix-lp1990446-kinetic
Merge into: ubuntu/+source/mako:ubuntu/kinetic-devel
Diff against target: 52 lines (+32/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix_exceptions_test.patch (+24/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Reporter Pending
git-ubuntu import Pending
Review via email: mp+430261@code.staging.launchpad.net

Description of the change

Fix for a FTBFS in the kinetic rebuild.

PPA: https://launchpad.net/~bryce/+archive/ubuntu/mako-fix-lp1990446

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks Bryce,
test builds look fine, you went the extra effort to find Debian bug, isolate the fix from the patch and all that.
+1 to get this resolved in kinetic

And by knowing the Debian sync will fix it there also is no follow up needed.

If you want to have a nit-pick then it is that (since you changed or actually reduced the patch) I think we usually would use
Origin: backport, ...
instead of
Origin: upstream, ...

And in the patch description you could say something like "isolated the test fixes from an upstream commit to just solve the current FTBFS in Ubuntu. The next sync from Debian will resolve it in 23.10."

But that is not really important here, it is up to you if you want to amend that before an upload.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Results: (from http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/?format=plain)
  mako @ amd64:
    http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/kinetic/amd64/m/mako/20220922_063705_abdde@/log.gz
    22.09.22 06:37:05 ✅ Triggers: mako/1.1.3+ds1-3ubuntu2~kinetic1
  mako @ arm64:
    http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/kinetic/arm64/m/mako/20220922_063918_4c3b5@/log.gz
    22.09.22 06:39:18 ✅ Triggers: mako/1.1.3+ds1-3ubuntu2~kinetic1
  mako @ armhf:
    http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/kinetic/armhf/m/mako/20220922_063818_4c3b5@/log.gz
    22.09.22 06:38:18 ✅ Triggers: mako/1.1.3+ds1-3ubuntu2~kinetic1
  mako @ ppc64el:
    http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/kinetic/ppc64el/m/mako/20220922_063731_4c3b5@/log.gz
    22.09.22 06:37:31 ✅ Triggers: mako/1.1.3+ds1-3ubuntu2~kinetic1
  mako @ s390x:
    http://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-bryce-mako-fix-lp1990446/kinetic/s390x/m/mako/20220922_063841_4253d@/log.gz
    22.09.22 06:38:41 ✅ Triggers: mako/1.1.3+ds1-3ubuntu2~kinetic1
Running: (none)
Waiting: (none)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches