Merge ~bryce/ubuntu/+source/logwatch:merge-v7.7-1-lunar into ubuntu/+source/logwatch:debian/sid

There is an odd autopkgtest failure, though I haven't isolated it as a regression of this release vs. a pre-existing issue or a non-issue:

Results: (from http://autopkgtest.ubuntu.com/results/autopkgtest-lunar-bryce-logwatch-merge-v7.7-1/?format=plain)
  logwatch @ amd64:
    10.12.22 09:50:17 Log 🗒️ ❌ Triggers: logwatch/7.7-1ubuntu1~lunar1
      basic-checks PASS 🟩
      syntax-check FAIL 🟥
      detail PASS 🟩
      su-l-check PASS 🟩
      apparmor-unmatched-entries PASS 🟩
      packages-and-report PASS 🟩
  logwatch @ arm64:
    10.12.22 09:57:52 Log 🗒️ ❌ Triggers: logwatch/7.7-1ubuntu1~lunar1
      basic-checks PASS 🟩
      syntax-check FAIL 🟥
      detail PASS 🟩
      su-l-check PASS 🟩
      apparmor-unmatched-entries PASS 🟩
      packages-and-report PASS 🟩
  logwatch @ armhf:
    10.12.22 09:10:10 Log 🗒️ ❌ Triggers: logwatch/7.7-1ubuntu1~lunar1
      basic-checks PASS 🟩
      syntax-check FAIL 🟥
      detail PASS 🟩
      su-l-check PASS 🟩
      apparmor-unmatched-entries PASS 🟩
      packages-and-report FAIL 🟥
  logwatch @ ppc64el:
    10.12.22 09:50:40 Log 🗒️ ❌ Triggers: logwatch/7.7-1ubuntu1~lunar1
      basic-checks PASS 🟩
      syntax-check FAIL 🟥
      detail PASS 🟩
      su-l-check PASS 🟩
      apparmor-unmatched-entries PASS 🟩
      packages-and-report PASS 🟩
  logwatch @ s390x:
    10.12.22 09:55:46 Log 🗒️ ❌ Triggers: logwatch/7.7-1ubuntu1~lunar1
      basic-checks PASS 🟩
      syntax-check FAIL 🟥
      detail PASS 🟩
      su-l-check PASS 🟩
      apparmor-unmatched-entries PASS 🟩
      packages-and-report PASS 🟩

The error is as follows:

String found where operator expected at /usr/share/logwatch/scripts/services/extreme-networks line 36, near "Logwatch ':all'"
 (Do you need to predeclare Logwatch?)
No such class use at /usr/share/logwatch/scripts/services/extreme-networks line 36, near "my use"
syntax error at /usr/share/logwatch/scripts/services/extreme-networks line 36, near "my use Logwatch "
BEGIN not safe after errors--compilation aborted at /usr/share/logwatch/scripts/services/extreme-networks line 37.
autopkgtest [09:24:24]: test syntax-check: -----------------------]
syntax-check FAIL non-zero exit status 253

The aforementioned issue was literally just a typo in the upstream codebase. Props to Autopkgtest!

The fix is trivial and I've forwarded it upstream:
https://sourceforge.net/p/logwatch/patches/77/

The branch and PPA are likewise updated. I'll update the description with the new autopkgtest results once they're available. (Hopefully I can assume they'll pass cleanly this time.)

Tests are better, but packages-and-report is failing in armhf.

As for the delta, I would suggest starting with the DEP8 one, which is large (but easy to maintain). And, as your latest fix confirms, the DEP8 tests are very useful.

+1 when the armhf test passes. If it's flaky, maybe something can be done to make it more resilient?

Approvers: bryce, ahasenack
Uploaders: bryce, ahasenack
MP auto-approved

I've run the armhf tests a few times and they all fail in packages-and-report. But the error is odd:

autopkgtest [16:01:35]: test packages-and-report: [-----------------------
Checking section SSHD exists in logwatch report for package openssh-server
Number of lines for the report:
autopkgtest [16:01:38]: test packages-and-report: -----------------------]

Maybe the sshd service simply isn't present on armhf? In any case, it looks like this test case has always failed on armhf, and doesn't hold up acceptance of the package:

  https://autopkgtest.ubuntu.com/packages/l/logwatch/lunar/armhf

I'll proceed with the upload, and file a bug for the wayward issue.

I checked and found that Miriam already forwarded the dep8 tests to Debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=996893) but no response from them yet.

Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/logwatch
Vcs-Git-Commit: e1df0b24deddb7054fb2859e961698cfe3778334
Vcs-Git-Ref: refs/heads/merge-v7.7-1-lunar

$ dput ubuntu ../logwatch_7.7-1ubuntu1_source.changes
Checking signature on .changes
Checking signature on .dsc
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading logwatch_7.7-1ubuntu1.dsc: done.
  Uploading logwatch_7.7.orig.tar.gz: done.
  Uploading logwatch_7.7-1ubuntu1.debian.tar.xz: done.
  Uploading logwatch_7.7-1ubuntu1_source.buildinfo: done.
  Uploading logwatch_7.7-1ubuntu1_source.changes: done.
Successfully uploaded packages.