Merge ~bryce/ubuntu/+source/logwatch:sru-lp1880211-groovy into ubuntu/+source/logwatch:ubuntu/groovy-devel
| Status: | Merged |
|---|---|
| Approved by: | Bryce Harrington |
| Approved revision: | ffedd599d3bf3d09fafd5cdd0fb2edb2a3a183bd |
| Merge reported by: | Christian Ehrhardt |
| Merged at revision: | ffedd599d3bf3d09fafd5cdd0fb2edb2a3a183bd |
| Proposed branch: | ~bryce/ubuntu/+source/logwatch:sru-lp1880211-groovy |
| Merge into: | ubuntu/+source/logwatch:ubuntu/groovy-devel |
| Diff against target: |
76 lines (+51/-0) 3 files modified
debian/changelog (+8/-0) debian/patches/0010-zz-zfs-detect-zfs-location.patch (+42/-0) debian/patches/series (+1/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Christian Ehrhardt (community) | Approve | ||
| git-ubuntu developers | Pending | ||
| Canonical Server | Pending | ||
|
Review via email:
|
|||
Description of the change
This corrects an earlier URL that pulled in upstream's reimplementation of our proposed fix, but which actually introduced a regression. The new code assumed Perl's -x operator considers the $PATH, but it doesn't appear to do so. Instead, we need to explicitly check abspaths in order to find zfs.
This also tightens up requirements to require both `zfs` and `zpool` to be available, and not just assume if one is the other will too.
Note that installing zfsutils-linux in LXC seems to be pretty fussy about kernel module versions, so my testing has been a bit synthetic (and I suppose is why the original issue slipped through). So extra attention on testing in review would be appreciated.
| Christian Ehrhardt (paelzer) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Along the review I've done tho the Hirsute MP this LGTM
+1