Merge ~bryce/ubuntu/+source/logwatch:sru.1797836-bionic into ubuntu/+source/logwatch:ubuntu/bionic-devel

Proposed by Bryce Harrington
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 4985770802e6e86928eaee8ef1d37b6dfad1b7f0
Merge reported by: Christian Ehrhardt 
Merged at revision: 4985770802e6e86928eaee8ef1d37b6dfad1b7f0
Proposed branch: ~bryce/ubuntu/+source/logwatch:sru.1797836-bionic
Merge into: ubuntu/+source/logwatch:ubuntu/bionic-devel
Diff against target: 63 lines (+41/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/ignore-ras-correctable-errors.patch (+31/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Pending
Review via email: mp+370585@code.staging.launchpad.net

Description of the change

Fixes LP: #1797836 for Ubuntu bionic by adding a backported patch from
logwatch 7.5.0.

PPA with test package: https://launchpad.net/~bryce/+archive/ubuntu/logwatch-sru-1797836/+packages
  $ sudo add-apt-repository ppa:bryce/logwatch-sru-1797836
  $ sudo apt-get update
  $ sudo apt-get install logwatch

Test case:
  $ now=$(date +"%b %d %T")
  $ uptime=$(cat /proc/uptime | cut -d' ' -f1)
  $ fake_message="${now} ${HOSTNAME} kernel: [${uptime}] RAS: Correctable Errors collector initialized"
  $ echo "${fake_message}" >> /var/log/kern.log
  $ logwatch --service kernel --range Today

  With the current Ubuntu version, logwatch will display a report
  showing the RAS error.

  With the PPA version, logwatch should show no output.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Current state:
 logwatch | 7.4.2-1ubuntu1 | xenial
 logwatch | 7.4.3+git20161207-2ubuntu1 | bionic
 logwatch | 7.4.3+git20161207-2ubuntu2 | cosmic
 logwatch | 7.5.0-1ubuntu1 | disco

Since we are not pushing the same version to Cosmic there is no need to extend it with per-release numbers.
This would do it:
  7.4.3+git20161207-2ubuntu1.1

All the rest (headers, patch, patch source, build, SRU, test) LGTM.
+1

You can fix up the version when sponsoring this yourself right?

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review, tagged and uploaded:

$ git push pkg upload/7.4.3+git20161207-2ubuntu1.1
Counting objects: 11, done.
Delta compression using up to 6 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.98 KiB | 253.00 KiB/s, done.
Total 11 (delta 7), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/logwatch
 * [new tag] upload/7.4.3+git20161207-2ubuntu1.1 -> upload/7.4.3+git20161207-2ubuntu1.1

$ dput ubuntu logwatch_7.4.3+git20161207-2ubuntu1.1_source.changes
Checking signature on .changes
gpg: /home/bryce/ubuntu/Logwatch/sru.1797836/logwatch_7.4.3+git20161207-2ubuntu1.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/ubuntu/Logwatch/sru.1797836/logwatch_7.4.3+git20161207-2ubuntu1.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading logwatch_7.4.3+git20161207-2ubuntu1.1.dsc: done.
  Uploading logwatch_7.4.3+git20161207-2ubuntu1.1.debian.tar.xz: done.
  Uploading logwatch_7.4.3+git20161207-2ubuntu1.1_source.buildinfo: done.
  Uploading logwatch_7.4.3+git20161207-2ubuntu1.1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is in -proposed, thereby setting merged

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches