Code review comment for ~bryce/ubuntu/+source/logwatch:eoan-merge-7.5.0-2

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Looks good, +1.

Just one tiny change perhaps, that you can do before uploading, is the changelog/commit message about the postfix delta drop.

Instead of:
    - debian/control: depend on postfix rather than exim4.
      + This is provided by postfix as of precise at least.

use:
    - debian/control: depend on postfix rather than exim4.
      + default-mta is provided by postfix as of precise at least.

And, this is a matter of personal choice, when explaining why something is being dropped (or added, or changed, or ...), we tend to use square brackets [] and reserve the indentation levels (+, -, +) for existing commit messages. So if you like that too, you could use:

    - debian/control: depend on postfix rather than exim4.
      [default-mta is provided by postfix as of precise at least]

Just to be clear, the above changes would be in the commit message, then the merge finish action would regenerate the changelog correctly.

review: Approve

« Back to merge proposal