Code review comment for ~bryce/ubuntu/+source/logwatch:eoan-merge-7.5.0-2

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> Good suggestions Andreas. I dug into debian and discovered they were indeed
> aware of the problem, incl. the specific bug that spawned our patch:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612634
>
> However, they appear to have chosen the approach of listing both the .0 and .1
> in their dist.conf/logfiles/maillog.conf file.
>
> Presumably if there is no .0, it's just ignored? If so, perhaps this change
> could simply be dropped from our changeset?

Something to check, I don't know the behavior. If you can check a few logrotate runs, see what happens, and turns out it's a no-op, then +1 for dropping that delta as well.

« Back to merge proposal