Ubuntu
librabbitmq package

Merge ~bryce/ubuntu/+source/librabbitmq:sru.1790657-xenial into ubuntu/+source/librabbitmq:ubuntu/xenial-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/librabbitmq
  3. sru.1790657-xenial
  4. Merge into ubuntu/xenial-devel
Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: 517e5e52c9b6c5a33fc5434c4c2e2b0253304c6d
Merge reported by: Bryce Harrington
Merged at revision: 517e5e52c9b6c5a33fc5434c4c2e2b0253304c6d
Proposed branch: ~bryce/ubuntu/+source/librabbitmq:sru.1790657-xenial
Merge into: ubuntu/+source/librabbitmq:ubuntu/xenial-devel
Diff against target: 147 lines (+126/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/fix-parameter-processing.patch (+117/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Canonical Server packageset reviewers Pending
Review via email: mp+370166@code.staging.launchpad.net

Description of the change

Straightforward backport of an upstream fix for parameter handling.

    LP: #1790657

Please also review the SRU details in the bug description.

A PPA with fixes for xenial, bionic, and cosmic is available here:
    https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq

Red/green testing in lxc can be done via:

    $ sudo apt-get -y install librabbitmq-dev
    $ sudo apt-get -y install amqp-tools

    ### Broken behavior:
    $ sudo amqp-consume --server=foobar:5672 -q queue cat
    both --server and --url options specify server host

    ### Fixed behavior:
    $ sudo apt-add-repository -y ppa:bryce/librabbitmq-sru-1790657
    $ sudo apt-get -y install librabbitmq-dev
    $ sudo amqp-consume --server=foobar:5672 -q queue cat
    Specifying the port number with --server is deprecated
    opening socket to foobar:5672

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

As with Bionic (change is identical) ...
Tested against PPA - ok
Upstream references - ok
Patch headers - perfect
Check upstream bug discussions - ok
Check LP bug - ok
SRU template - ok

Given how long things are broken this seems rather unimportant, but OTOH a very low hanging fruit.
Thanks Bryce for prepping that.
+1 on the MP

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review Christian.

$ git ubuntu tag --upload
$ git push pkg upload/0.7.1-1ubuntu0.1
Counting objects: 11, done.
Delta compression using up to 6 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 2.62 KiB | 892.00 KiB/s, done.
Total 11 (delta 5), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/librabbitmq
 * [new tag] upload/0.7.1-1ubuntu0.1 -> upload/0.7.1-1ubuntu0.1
$ dput ubuntu ../librabbitmq_0.7.1-1ubuntu0.1_source.changes
Checking signature on .changes
gpg: ../librabbitmq_0.7.1-1ubuntu0.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: ../librabbitmq_0.7.1-1ubuntu0.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading librabbitmq_0.7.1-1ubuntu0.1.dsc: done.
  Uploading librabbitmq_0.7.1-1ubuntu0.1.debian.tar.xz: done.
  Uploading librabbitmq_0.7.1-1ubuntu0.1_source.changes: done.
Successfully uploaded packages.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches