Merge ~bryce/ubuntu/+source/librabbitmq:sru.1790657-xenial into ubuntu/+source/librabbitmq:ubuntu/xenial-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Bryce Harrington | ||||
Approved revision: | 517e5e52c9b6c5a33fc5434c4c2e2b0253304c6d | ||||
Merge reported by: | Bryce Harrington | ||||
Merged at revision: | 517e5e52c9b6c5a33fc5434c4c2e2b0253304c6d | ||||
Proposed branch: | ~bryce/ubuntu/+source/librabbitmq:sru.1790657-xenial | ||||
Merge into: | ubuntu/+source/librabbitmq:ubuntu/xenial-devel | ||||
Diff against target: |
147 lines (+126/-0) 3 files modified
debian/changelog (+8/-0) debian/patches/fix-parameter-processing.patch (+117/-0) debian/patches/series (+1/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server packageset reviewers | Pending | ||
Review via email: mp+370166@code.staging.launchpad.net |
Description of the change
Straightforward backport of an upstream fix for parameter handling.
LP: #1790657
Please also review the SRU details in the bug description.
A PPA with fixes for xenial, bionic, and cosmic is available here:
https:/
Red/green testing in lxc can be done via:
$ sudo apt-get -y install librabbitmq-dev
$ sudo apt-get -y install amqp-tools
### Broken behavior:
$ sudo amqp-consume --server=
both --server and --url options specify server host
### Fixed behavior:
$ sudo apt-add-repository -y ppa:bryce/
$ sudo apt-get -y install librabbitmq-dev
$ sudo amqp-consume --server=
Specifying the port number with --server is deprecated
opening socket to foobar:5672
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
As with Bionic (change is identical) ...
Tested against PPA - ok
Upstream references - ok
Patch headers - perfect
Check upstream bug discussions - ok
Check LP bug - ok
SRU template - ok
Given how long things are broken this seems rather unimportant, but OTOH a very low hanging fruit.
Thanks Bryce for prepping that.
+1 on the MP