Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute
Revision history for this message
| Matthias Andree (matthias-andree) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
5c6b958
demo site
(Get the code!)
Bryce,
as upstream fetchmail maintainer: thanks for writing such a test, I am considering taking it into upstream fetchmail 6.5 (Git branch legacy_6x).
One remark, writing network-based self-tests for FreeBSD's OpenVPN package I figured that hardcoding ports as done here can cause false-negative test results so I suggest to either retry with waiting and random different ports and random delay times a few times, and ultimately going for a three-state result (at least upstream I can exit 77 to "SKIP" a test within the automake testing framework).