Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute

> My thought process here was that running the upstream testsuite is a standard
> practice for inclusion in autopkgtests. fetchmail has a handful of test
> cases, triggered by running make check, via Perl's standard testing tooling:

IMO running upstream more code level tests (like unit tests) makes sense when you are testing a library, where when it is installed you want it behaving well when imported by other programs. AFAICS fetchmail ships only the binaries, docs, and config files. In short, we do not care if the library is behaving as expected because there is no library, what really matters is what we ship as a .deb. That's what autopkgtest was created for, test the installed binary packages.

I am not telling you to not do this, but this is how I rationale about testing installed version of the packages.

> Admittedly, these test cases are super trivial, which is why I went ahead with
> creating the POP3 test. But, perhaps future development will add more tests,
> and in any case they seemed to pass (for me), so figured it couldn't hurt to
> hook them up. It doesn't look like 'make check' is triggered during the
> fetchmail build process, so to me it seemed appropriate to do in a DEP8.

Maybe a good idea is to submit a salsa MR to call "make check" during the build process.