Ubuntu
exim4 package

Merge ~bryce/ubuntu/+source/exim4:fix-lp1927755-bionic into ubuntu/+source/exim4:ubuntu/bionic-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/exim4
  3. fix-lp1927755-bionic
  4. Merge into ubuntu/bionic-devel
Proposed by Bryce Harrington
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Bryce Harrington
Merged at revision: 6cbf24a464ec1e316d356cbaf6001964cc4ffd1b
Proposed branch: ~bryce/ubuntu/+source/exim4:fix-lp1927755-bionic
Merge into: ubuntu/+source/exim4:ubuntu/bionic-devel
Diff against target: 71 lines (+49/-0)
3 files modified
debian/changelog (+10/-0)
debian/patches/fix-coding-typo.patch (+38/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Athos Ribeiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+429330@code.staging.launchpad.net

Description of the change

Backports a fix to a regression caused by a CVE update last year to the bionic version of exim4. The issue only crops up when people self-compile our exim4 package, however this workflow seems to not be unusual if, for example, people want to enable some non-standard functionality or modules. Even though importance is Low, the error is pretty obvious and the fix super straightforward.

PPA: https://launchpad.net/~bryce/+archive/ubuntu/exim4-fix-lp1927755

Results: (from http://autopkgtest.ubuntu.com/results/autopkgtest-bionic-bryce-exim4-fix-lp1927755/?format=plain)
  exim4 @ amd64:
    01.09.22 21:56:52 Log 🗒️ ✅ Triggers: exim4/4.90.1-1ubuntu1.10~bionic1
  exim4 @ arm64:
    01.09.22 21:57:48 Log 🗒️ ✅ Triggers: exim4/4.90.1-1ubuntu1.10~bionic1
  exim4 @ armhf:
    01.09.22 21:57:32 Log 🗒️ ✅ Triggers: exim4/4.90.1-1ubuntu1.10~bionic1
  exim4 @ ppc64el:
    01.09.22 21:55:30 Log 🗒️ ✅ Triggers: exim4/4.90.1-1ubuntu1.10~bionic1
  exim4 @ s390x:
    01.09.22 21:56:47 Log 🗒️ ✅ Triggers: exim4/4.90.1-1ubuntu1.10~bionic1

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce!

It seems like the SRU template is at LP: #1927755, but the changelog references LP: #1971489.

Also, I am curious about how the SRU team will take this proposal, since it is an issue in the source package, but not in the binary package. This partially fits into the FTBFS case in https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases, where one could read as a suggestion to stage the SRU (block-proposed). Still, this FTBF(reconfigured)S.

Now, if we are modifying this through an SRU, does it mean we support the source modifications as well? If so, should we further test the modified sources (e.g., run autopkgtests on a modified build as well)?

In the other hand, as mentioned in the description, the error is pretty obvious and the fix super straightforward.

This LGTM. I will add a needs info tag so we can fix the bug reference in the changelog.

review: Needs Information
Revision history for this message
Bryce Harrington (bryce) wrote (last edit ):

Thanks Athos, I've fixed the bug # (not sure how that got switched up) and force pushed.

Regarding about SRU team acceptability I agree this seems an interesting edge case. In favor of accepting it I'd argue that this fixes a regression caused by an earlier security update. If it does get rejected, at least this doesn't represent a huge time investment - the issue was simple and fix straightforward.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM! Thanks, Bryce :)

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: bryce, athos-ribeiro
Uploaders: bryce, athos-ribeiro
MP auto-approved

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks; uploaded:

$ grep Vcs exim4_4.90.1-1ubuntu1.10_source.changes
Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/exim4
Vcs-Git-Commit: 6cbf24a464ec1e316d356cbaf6001964cc4ffd1b
Vcs-Git-Ref: refs/heads/fix-lp1927755-bionic

$ debsponsor exim4_4.90.1-1ubuntu1.10_source.changes
 signfile dsc exim4_4.90.1-1ubuntu1.10.dsc A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

 fixup_buildinfo exim4_4.90.1-1ubuntu1.10.dsc exim4_4.90.1-1ubuntu1.10_source.buildinfo
 signfile buildinfo exim4_4.90.1-1ubuntu1.10_source.buildinfo A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

 fixup_changes dsc exim4_4.90.1-1ubuntu1.10.dsc exim4_4.90.1-1ubuntu1.10_source.changes
 fixup_changes buildinfo exim4_4.90.1-1ubuntu1.10_source.buildinfo exim4_4.90.1-1ubuntu1.10_source.changes
 signfile changes exim4_4.90.1-1ubuntu1.10_source.changes A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

Successfully signed dsc, buildinfo, changes files
$ dput ubuntu exim4_4.90.1-1ubuntu1.10_source.changes
Checking signature on .changes
gpg: /home/bryce/pkg/Exim4/fix-lp1927755/exim4_4.90.1-1ubuntu1.10_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/Exim4/fix-lp1927755/exim4_4.90.1-1ubuntu1.10.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading exim4_4.90.1-1ubuntu1.10.dsc: done.
  Uploading exim4_4.90.1-1ubuntu1.10.debian.tar.xz: done.
  Uploading exim4_4.90.1-1ubuntu1.10_source.buildinfo: done.
  Uploading exim4_4.90.1-1ubuntu1.10_source.changes: done.
Successfully uploaded packages.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches