Merge ~bryce/ubuntu/+source/clamav:merge-v0.103.7adfsg-1-lunar into ubuntu/+source/clamav:debian/sid

Proposed by Bryce Harrington
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Bryce Harrington
Merged at revision: 98b94541463c591017f35d355cb897e50ee74326
Proposed branch: ~bryce/ubuntu/+source/clamav:merge-v0.103.7adfsg-1-lunar
Merge into: ubuntu/+source/clamav:debian/sid
Diff against target: 59 lines (+20/-2)
3 files modified
debian/changelog (+17/-0)
debian/clamav-base.postinst.in (+1/-1)
debian/control (+2/-1)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Christian Ehrhardt  (community) Approve
Canonical Server Reporter Pending
Review via email: mp+433389@code.staging.launchpad.net

Description of the change

Merge with Debian's package. The warning check still hasn't been picked up by Debian so we still carry it.

It appears last merge a translation update was included. I'm not certain how that happened but it's unneeded and could cause conflict with new merges, so I've omitted it from this merge.

PPA with test packages: https://launchpad.net/~bryce/+archive/ubuntu/clamav-merge-v0.103.7adfsg-1

    $ sudo add-apt-repository -yus ppa:bryce/clamav-merge-v0.103.7adfsg-1
    $ sudo apt-get install clamav

* gnome-terminal
  - lp-test-ppa ppa:bryce/clamav-merge-v0.103.7adfsg-1 --release lunar --showpass

Usual tags pushed for review:
  - tags/old/debian 9531a184
  - tags/new/debian 9c5035f6
  - tags/old/ubuntu 5326e345
  - tags/logical/0.103.6+dfsg-1ubuntu1 57773cbb
  - tags/reconstruct/0.103.6+dfsg-1ubuntu1 cdfa6e6b

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tags look ok:
$ git diff bryce/old/ubuntu bryce/logical/0.103.6+dfsg-1ubuntu1 | diffstat
 changelog | 7 -------
 control | 3 +--
 2 files changed, 1 insertion(+), 9 deletions(-)

using bryce/logical/0.103.6+dfsg-1ubuntu1 to compare delta

But:
clamav | 0.103.7+dfsg-1+b1 | unstable | amd64, arm64, armel, armhf, i386, mips64el, mipsel, ppc64el, s390x
 clamav | 0.103.6+dfsg-1ubuntu1 | lunar | source, amd64, arm64, armhf, ppc64el, riscv64, s390x

Ok, picked the latest

1: ce33b13e2 ! 1: 672be8596
ok commit message change
2: 051931085 < -: --------- * Update translations
you mentioned you dropped them, and it is unclear where they came from - hmm
-: --------- > 2: 0b7801767 * Dropped: - Update translations
-: --------- > 3: 880b64f3a merge-changelogs
-: --------- > 4: 23714373c reconstruct-changelog
-: --------- > 5: 98b945414 update-maintainer

So overall straight forward and ok, if not for the translation riddle.

They would still apply at least.
Did you find where they came from?
That upload was yours or am I completely mistaken?

clamav (0.103.6+dfsg-1ubuntu1) kinetic; urgency=medium

  * clamav-base.postinst.in: Quell warning from check for clamav user
    (LP: #1920217)

 -- Bryce Harrington <email address hidden> Wed, 18 May 2022 17:26:41 -070

I'm +1 on the proposed merge, but would like to understand the riddle.
OTOH do not spend too much time on it, I'm just curious.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: bryce, paelzer
Uploaders: bryce, paelzer
MP auto-approved

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Uploaded; waiting on autopkgtest runs.

Revision history for this message
Bryce Harrington (bryce) wrote :

> Did you find where they came from?
> That upload was yours or am I completely mistaken?

Yes, that was from my upload. It's not in my git branch though, thus my surprise. I did a bit more digging to understand it.

It looks like clamav is set up to do this automatically during `debuild -S`:

    # d/rules
    override_dh_auto_clean:
        # Update .po files for debconf.
 debconf-updatepo
        dh_auto_clean

So it seems to be an intentional behavior, although I can't recall running across this with other packages. I'm curious why there are changes needed to the po files; the delta we carry does not affect strings at all, so this seems due just to some O/S skew between us and Debian.

If this were an SRU I'd be a bit more concerned about including such changes, but since this is a merge it seems just part of the process I guess. I don't see a documented way to skip it other than commenting out the debconf-updatepo line above.

Anyway, other than the surprise in my git branch, this behavior seems benign so I'm leaving it as is.

Revision history for this message
Bryce Harrington (bryce) wrote :

Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/clamav
Vcs-Git-Commit: 98b94541463c591017f35d355cb897e50ee74326
Vcs-Git-Ref: refs/heads/merge-v0.103.7adfsg-1-lunar

$ dput ubuntu ../clamav_0.103.7+dfsg-1ubuntu1_source.changes
D: Setting host argument.
Checking signature on .changes
Checking signature on .dsc
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading clamav_0.103.7+dfsg-1ubuntu1.dsc: done.
  Uploading clamav_0.103.7+dfsg.orig.tar.xz: done.
  Uploading clamav_0.103.7+dfsg-1ubuntu1.debian.tar.xz: done.
  Uploading clamav_0.103.7+dfsg-1ubuntu1_source.buildinfo: done.
  Uploading clamav_0.103.7+dfsg-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

This finally migrated

clamav | 0.103.7+dfsg-1ubuntu1 | lunar

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches