Merge ~bryce/ubuntu/+source/bash:ubuntu/bionic-devel into ubuntu/+source/bash:ubuntu/bionic-devel

Proposed by Bryce Harrington
Status: Merged
Approved by: Andreas Hasenack
Approved revision: cf1670027b9000c6eb6386f62701b4408886c8d5
Merge reported by: Bryce Harrington
Merged at revision: cf1670027b9000c6eb6386f62701b4408886c8d5
Proposed branch: ~bryce/ubuntu/+source/bash:ubuntu/bionic-devel
Merge into: ubuntu/+source/bash:ubuntu/bionic-devel
Diff against target: 174 lines (+152/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/bash44-020.diff (+144/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Canonical Server Core Reviewers Pending
Canonical Server Pending
Review via email: mp+368574@code.staging.launchpad.net

Description of the change

Backport of an upstream fix to a cpu hang when waiting on background tasks.

PPA available for testing is at
https://launchpad.net/~bryce/+archive/ubuntu/bash-sru-19-010-1

I was not able to reproduce the hang myself, but apparently it can take days or weeks to reproduce. However, the fix was taken upstream and looks clearly correct to me. I'm confident given enough run time it would reproduce. It may be difficult to positively test for the bug's absence however.

I'm assuming that the target branch for this should be ubuntu/cosmic-devel; I couldn't find documentation to this effect however it seems to be what others are targeting to. Let me know if it's wrong.

I'm unclear if any tags are needed for SRU bugs but am gathering that none are. Again, let me know if otherwise.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Same comments as with the cosmic MP at https://code.launchpad.net/~bryce/ubuntu/+source/bash/+git/bash/+merge/368573.
- add dep3
- don't use -proposed

Revision history for this message
Bryce Harrington (bryce) wrote :

Updated; same changes as the other branch. Thanks again.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Pushing upload tag, and then you can dput:

$ git push pkg upload/4.4.18-2ubuntu1.2
Enumerating objects: 16, done.
Counting objects: 100% (16/16), done.
Delta compression using up to 2 threads
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 2.72 KiB | 558.00 KiB/s, done.
Total 11 (delta 7), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/bash
 * [new tag] upload/4.4.18-2ubuntu1.2 -> upload/4.4.18-2ubuntu1.2

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, pushed.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches