ppa-dev-tools

Merge ~bryce/ppa-dev-tools/+git/ppa-dev-tools-1:fix-lp2038649-tests-result-duplicated into ~bryce/ppa-dev-tools/+git/ppa-dev-tools-1:main

  1. Git
  2. lp:~bryce/ppa-dev-tools/+git/ppa-dev-tools-1
  3. fix-lp2038649-tests-result-duplicated
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 39a8cb0df2c351c911b4e43b2d473d1e04497ef4
Proposed branch: ~bryce/ppa-dev-tools/+git/ppa-dev-tools-1:fix-lp2038649-tests-result-duplicated
Merge into: ~bryce/ppa-dev-tools/+git/ppa-dev-tools-1:main
Diff against target: 79 lines (+37/-8)
2 files modified
ppa/result.py (+6/-7)
tests/test_result.py (+31/-1)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
PpaDevTools Developers Pending
Canonical Server Reporter Pending
Review via email: mp+453588@code.staging.launchpad.net

Description of the change

Implements a fix for display of too many results.

This was due to double-looping over the results, so if there were 2 results 4 would be displayed, if 3 then 9, etc. Fun!

I took the opportunity to also implement tests for show_results().

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos) wrote :

LGTM! Thank you, Bryce :)

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review Athos! Landed

stirling: ~/src/PpaDevTools/ppa-dev-tools-bugfix$ git merge --ff-only fix-lp2038649-tests-result-duplicated
Updating 3ce7aaf..0613b8d
Fast-forward
 ppa/result.py | 13 ++++++-------
 tests/test_result.py | 32 +++++++++++++++++++++++++++++++-
 2 files changed, 37 insertions(+), 8 deletions(-)
stirling: ~/src/PpaDevTools/ppa-dev-tools-bugfix$ git push
Enumerating objects: 15, done.
Counting objects: 100% (15/15), done.
Delta compression using up to 12 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.64 KiB | 1.64 MiB/s, done.
Total 10 (delta 8), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   3ce7aaf..0613b8d main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: