Merge ppa-dev-tools:fix-lp2038651-bionic-not-included into ppa-dev-tools:main
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 3ce7aaf4b8b5a457ca4b228a7758a1b2ec4216c7 | ||||
| Proposed branch: | ppa-dev-tools:fix-lp2038651-bionic-not-included | ||||
| Merge into: | ppa-dev-tools:main | ||||
| Diff against target: |
84 lines (+38/-3) 2 files modified
scripts/ppa (+1/-0) tests/test_scripts_ppa.py (+37/-3) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher (community) | Approve | ||
| Andreas Hasenack (community) | Approve | ||
| PpaDevTools Developers | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
Simple fix for issue discovered and reported by Sebastien Bacher, that the trigger list misses packages targeting ESM releases.
I included with this change an expansion of the relevant test case to cover this issue. Running 'make check' without the fix applied will result in a test failure, and with it applied it then passes.
Admittedly, the test case has some bitrot potential in that eventually even ESM releases will become EOL, so eventually this test case will start failing when 'bionic' hits that point. But this isn't the only test case with such an issue. (Eventually these will need fixed by mocking distro-info to allow hardcoding the releases, however that's a larger scope cleanup than this bugfix.)
| Andreas Hasenack (ahasenack) wrote | # |
| Bryce Harrington (bryce) wrote | # |
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
supported_esm() currently also includes trusty and xenial. Should we test for those as well, or are you worried about the test becoming wrong once those become unsupported via esm?