ppa-dev-tools

Merge ppa-dev-tools:fix-lp2025484-missing-test-name into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. fix-lp2025484-missing-test-name
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: c054b7eb228d4bd91d4cc92842581b76865178ea
Proposed branch: ppa-dev-tools:fix-lp2025484-missing-test-name
Merge into: ppa-dev-tools:main
Diff against target: 105 lines (+83/-0)
2 files modified
ppa/result.py (+3/-0)
tests/test_result.py (+80/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
PpaDevTools Developers Pending
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+450190@code.staging.launchpad.net

Description of the change

This adds a fix requested by mwhudson today and bdrung earlier to address a change in autopkgtest log file format that was causing some corruption in results shown by ppa tests.

The fix is pretty trivial but I've taken this opportunity to also implement a corresponding test case with some snippets of example log files.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) :
review: Needs Information
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the quick review, response to the question below:

Revision history for this message
Andreas Hasenack (ahasenack) :
review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Andreas, I decided you were right, and incorporated your suggestion and landed the branch:

stirling: ~/src/PpaDevTools/ppa-dev-tools-bugfix$ git merge --ff-only fix-lp2025484-missing-test-name
Updating 7bef7a0..c56a856
Fast-forward
 ppa/result.py | 3 +++
 tests/test_result.py | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+)
stirling: ~/src/PpaDevTools/ppa-dev-tools-bugfix$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   7bef7a0..c56a856 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: