ppa-dev-tools

Merge ppa-dev-tools:refactor-autopkgtest-results into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. refactor-autopkgtest-results
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merged at revision: 6c63268fdbe01cbd7ca456a0eac6c2313116f551
Proposed branch: ppa-dev-tools:refactor-autopkgtest-results
Merge into: ppa-dev-tools:main
Diff against target: 286 lines (+126/-31)
5 files modified
ppa/ppa.py (+25/-0)
ppa/result.py (+1/-1)
scripts/ppa (+14/-24)
tests/test_ppa.py (+78/-5)
tests/test_result.py (+8/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
PpaDevTools Developers Pending
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+449980@code.staging.launchpad.net

Description of the change

Refactors logic out of the tests command relating to Autopkgtest results into a new
get_autopkgtest_results() routine, with a corresponding test case.

The test case was the most challenging part, but I feel its finally adequate. I plan to add some functionality for filtering and refining the test results displayed when running 'ppa tests <ppa>' so that you can limit to particular packages, releases, etc. However, before getting into that I wanted a solid test to base the work on. In implementing this I can see some additional refactoring that could make the test more concise and narrowly focused, however I'll leave that to the planned followup work.

In addition to this commit, I'm including several testing-related refinements that feel like they go along with this.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, just two minor optional comments.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, updated and landed:

stirling: ~/src/PpaDevTools/ppa-dev-tools-feature-rdepends-testing$ git merge --ff-only refactor-autopkgtest-results
Updating c56a856..6c63268
Fast-forward
 ppa/ppa.py | 25 +++++++++++++++++++++++++
 ppa/result.py | 2 +-
 scripts/ppa | 38 ++++++++++++++------------------------
 tests/test_ppa.py | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
 tests/test_result.py | 9 ++++++++-
 5 files changed, 126 insertions(+), 31 deletions(-)
stirling: ~/src/PpaDevTools/ppa-dev-tools-feature-rdepends-testing$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   c56a856..6c63268 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: