ppa-dev-tools

Merge ppa-dev-tools:set-command-private-ppa into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. set-command-private-ppa
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: a116288136ae712e726d5e8f7830b64ca77830ba
Proposed branch: ppa-dev-tools:set-command-private-ppa
Merge into: ppa-dev-tools:main
Diff against target: 395 lines (+173/-31)
7 files modified
ppa/ppa.py (+24/-0)
ppa/ppa_group.py (+3/-1)
scripts/ppa (+43/-21)
tests/helpers.py (+5/-2)
tests/smoketest_ppa_set (+70/-0)
tests/test_ppa_group.py (+10/-0)
tests/test_scripts_ppa.py (+18/-7)
Reviewer Review Type Date Requested Status
Lena Voytek (community) Approve
Canonical Server packageset reviewers Pending
PpaDevTools Developers Pending
Canonical Server Reporter Pending
Review via email: mp+447032@code.staging.launchpad.net

Description of the change

Implements support for creating private PPAs and toggling PPAs public vs. private.

Creating private PPAs requires special authorization that I don't seem to have, with the result that I've not been able to verify that this actually works correctly "live". However, I've included checks for some of the authorization errors I've hit, and implemented a slew of unit tests. I'll try to find someone with access to do the live verification, but apart from that I think this code is ready for review and landing.

As usual, to run the testsuite, do:

    $ make check

or

    $ pytest-3

And the smoketest has been updated to include toggling --private:

    $ ./tests/smoketest_ppa_set

However as mentioned, unless you have authorization to modify privacy on PPAs that will merely generate errors.

To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

LGTM! just one note for one of the help strings

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks Lena, I've squashed that change in, updated this branch, and landed to main.

stirling: ~/src/PpaDevTools/ppa-dev-tools-commands-set$ git merge --ff-only set-command-private-ppa
Updating 4fa781a..0f7a075
Fast-forward
 ppa/ppa.py | 24 ++++++++++++++++++++++++
 ppa/ppa_group.py | 4 +++-
 scripts/ppa | 64 +++++++++++++++++++++++++++++++++++++++++++---------------------
 tests/helpers.py | 7 +++++--
 tests/smoketest_ppa_set | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/test_ppa_group.py | 10 ++++++++++
 tests/test_scripts_ppa.py | 25 ++++++++++++++++++-------
 7 files changed, 173 insertions(+), 31 deletions(-)
 create mode 100755 tests/smoketest_ppa_set
stirling: ~/src/PpaDevTools/ppa-dev-tools-commands-set$ git push
Enumerating objects: 57, done.
Counting objects: 100% (57/57), done.
Delta compression using up to 12 threads
Compressing objects: 100% (40/40), done.
Writing objects: 100% (47/47), 6.94 KiB | 6.94 MiB/s, done.
Total 47 (delta 29), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   4fa781a..0f7a075 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: