Merge ppa-dev-tools:refactor_results_display into ppa-dev-tools:main
Proposed by
Bryce Harrington
| Status: | Merged |
|---|---|
| Merge reported by: | Bryce Harrington |
| Merged at revision: | 1cf5354761fa770c88b716b9352d438f205d644d |
| Proposed branch: | ppa-dev-tools:refactor_results_display |
| Merge into: | ppa-dev-tools:main |
| Diff against target: |
117 lines (+48/-19) 2 files modified
ppa/result.py (+40/-0) scripts/ppa (+8/-19) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lena Voytek (community) | Approve | ||
| Canonical Server packageset reviewers | Pending | ||
| PpaDevTools Developers | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
There was some remaining tech debt for the tests command in the code that prints out triggers and test results. I untangled the code and split apart the data lookup code from the display code. I've got worked planned here to add better filtering, different output file formats, etc. so this lays some of the foundation for that.
As a result, this is almost entirely just refactoring. There's only one minor user-visible change but it's pretty minor.
There's a few features planned that this code restructuring will facilitate.
To post a comment you must log in.
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The refactor looks good to me! I think it's a good improvement for handling formatting in the future. Added some additional comments for future reference but as is I approve