Merge ppa-dev-tools:fix-lp1990244-create-for-owner into ppa-dev-tools:main
| Status: | Merged |
|---|---|
| Merged at revision: | 9dbaa6f713ae958ad415607c771549434fa1db93 |
| Proposed branch: | ppa-dev-tools:fix-lp1990244-create-for-owner |
| Merge into: | ppa-dev-tools:main |
| Diff against target: |
732 lines (+207/-111) 8 files modified
NEWS.md (+9/-0) ppa/ppa.py (+35/-29) ppa/ppa_group.py (+9/-9) scripts/ppa (+38/-18) tests/helpers.py (+3/-2) tests/test_ppa.py (+32/-32) tests/test_ppa_group.py (+5/-5) tests/test_scripts_ppa.py (+76/-16) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lena Voytek (community) | Approve | ||
| Canonical Server packageset reviewers | Pending | ||
| PpaDevTools Developers | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
This adds the ability to create PPAs against other teams that your LP user account has access to, fixing LP: #1990244. You can specify the team by a command line argument, config file variable, or the ppa address.
For example:
$ ./scripts/ppa create --team ppa-dev-tools-devs foobar
PPA 'foobar' created for the following architectures:
i386, amd64, armhf, ppc64el, s390x, arm64, powerpc
The PPA can be viewed at:
https:/
...
$ ./scripts/ppa create ppa-dev-
PPA 'example' created for the following architectures:
i386, amd64, armhf, ppc64el, s390x, arm64, powerpc
The PPA can be viewed at:
https:/
...
| Christian Ehrhardt (paelzer) wrote | # |
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
I like this, I do not feel I was able to do a full review - but for whatever it is worth it LGTM.
Furthermore I have left a few small comments inline for you to think about.