Merge ppa-dev-tools:add_dependent_packages_function into ppa-dev-tools:main

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: cf1fbe6179a33e75d5b2173f41b5d670aa58c65a
Proposed branch: ppa-dev-tools:add_dependent_packages_function
Merge into: ppa-dev-tools:main
Diff against target: 301 lines (+261/-0)
2 files modified
ppa/suite.py (+55/-0)
tests/test_suite.py (+206/-0)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+440454@code.staging.launchpad.net

Description of the change

This branch finally implements the core mechanics of this feature, the mapping of provided binary packages of some source packages to the reverse dependencies of others. The dependent_packages() API is introduced to provide a way to look up for a given source packages, the other packages that should be tested along with it.

I mulled over a few different ideas for the API name before setting on "dependent_packages()" but am still unsure that's the best name. Alternative ideas would be welcome, and I reserve the option to rename this later if inspiration strikes. :-)

This API will be used to generate all the various trigger URLs. I wanted to include a smoketest to showcase this, but this is already plenty to review.

This branch just introduces the core data structure and basic lookups. It doesn't handle recursive lookups and some corner cases like packages with no build dependencies, but those enhancements should be straightforward modifications, and will be tackled in a future MP.

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM. Thanks, Bryce!

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, landed:

To git+ssh://git.launchpad.net/ppa-dev-tools
   100b629..272c487 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: