ppa-dev-tools

Merge ppa-dev-tools:enable_source_binary_packages_in_suite into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. enable_source_binary_packages_in_suite
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: a7b937ee2404e55b11392e26a735537e7efa72a6
Proposed branch: ppa-dev-tools:enable_source_binary_packages_in_suite
Merge into: ppa-dev-tools:main
Diff against target: 245 lines (+76/-33)
5 files modified
ppa/binary_package.py (+1/-0)
ppa/source_package.py (+1/-1)
ppa/suite.py (+12/-8)
tests/test_source_package.py (+1/-1)
tests/test_suite.py (+61/-23)
Reviewer Review Type Date Requested Status
Lena Voytek (community) Approve
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+440292@code.staging.launchpad.net

Description of the change

Incorporates the recently added SourcePackage and BinaryPackage classes into the respective member properties of the Suite class.

Also fixes a couple unfortunate typos that I think I introduced when addressing the review feedback from the last MP. The tests had caught these errors.

To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

All changes look good to me! No issues or nitpicks from what I can see

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Excellent, thanks Lena, landed branch to main:

Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   22e2642..a7b937e main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: