ppa-dev-tools

Merge ppa-dev-tools:set-command-architecture-option into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. set-command-architecture-option
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: cf6a8427699148b3b3055eb3dc810b0712632624
Proposed branch: ppa-dev-tools:set-command-architecture-option
Merge into: ppa-dev-tools:main
Diff against target: 283 lines (+83/-49)
5 files modified
ppa/ppa.py (+10/-5)
ppa/ppa_group.py (+1/-3)
scripts/ppa (+14/-33)
tests/helpers.py (+3/-6)
tests/test_scripts_ppa.py (+55/-2)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+439599@code.staging.launchpad.net

Description of the change

Continuation of work on the ppa create/set command. This branch focuses on the addition of tests for covering --architecture's implementation, along with some assorted cleanups.

This also brings in the first user for the recently added unpack_to_dict().

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM!

Thanks, Bryce

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, pushed!

Total 40 (delta 28), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   0ff0e30..4bb2310 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: