Merge ppa-dev-tools:set-command-basic-options into ppa-dev-tools:main
| Status: | Merged |
|---|---|
| Merge reported by: | Bryce Harrington |
| Merged at revision: | 321446afc19cda9b835c1e2514605a97eb42e6f2 |
| Proposed branch: | ppa-dev-tools:set-command-basic-options |
| Merge into: | ppa-dev-tools:main |
| Diff against target: |
462 lines (+222/-52) 6 files modified
ppa/constants.py (+2/-1) ppa/ppa_group.py (+9/-7) scripts/ppa (+120/-5) tests/helpers.py (+16/-0) tests/test_ppa_group.py (+0/-18) tests/test_scripts_ppa.py (+75/-21) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andreas Hasenack (community) | Approve | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
True testing of all this stuff requires running against Launchpad, which
the unit tests don't do. Here's some example commandlines I used in my
own testing:
# Basic creation
$ ./scripts/ppa create test-set-command
# Architectures
$ ./scripts/ppa set test-set-command --architecture armhf,powerpc,s390x
$ ./scripts/ppa set test-set-command --default-
$ ./scripts/ppa set test-set-command --all-architectures
After running each command, load up the PPA webpage in the browser and
verify the settings took. I didn't run into any problems with any of
these, and would expect them to Just Work(tm) for everyone, so if you
spot any issues let me know.
| Andreas Hasenack (ahasenack) | # |
| Andreas Hasenack (ahasenack) | # |
| Andreas Hasenack (ahasenack) | # |
| Andreas Hasenack (ahasenack) | # |
| Bryce Harrington (bryce) | # |
| Bryce Harrington (bryce) wrote | # |
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Fixed help text for --disable