ppa-dev-tools

Merge ppa-dev-tools:set-command into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. set-command
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: b6866c83422f9c1d55beea458a454211b50e3a23
Proposed branch: ppa-dev-tools:set-command
Merge into: ppa-dev-tools:main
Diff against target: 281 lines (+143/-15)
3 files modified
scripts/ppa (+89/-3)
tests/helpers.py (+16/-0)
tests/test_scripts_ppa.py (+38/-12)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server Core Reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+434685@code.staging.launchpad.net

Description of the change

This is the first piece of a batch of commits for implementing the 'ppa set' command. This first MP just provides three super basic settings, that are already supported by the 'ppa create' command, and generalizes the code so it can be reused for both set and create.

This is one of those situations where the functionality itself was simple to implement, and all the real work was in crafting the test cases. So part of the reason for sending this one initial commit by itself is to get feedback on the testing approach in isolation from all the other settings.

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce!

The commit message has a duplication in "... the same set of of configuration...".

I also left a couple minor comments inline regarding duplication of value testing, but those should not be blockers.

LGTM.

Revision history for this message
Athos Ribeiro (athos-ribeiro) :
review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, will make those changes and land.

Revision history for this message
Bryce Harrington (bryce) wrote :

Pushed.

$ git push bryce set-command
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 12 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (7/7), 2.13 KiB | 545.00 KiB/s, done.
Total 7 (delta 5), reused 0 (delta 0)
remote:
remote: Create a merge proposal for 'set-command' on Launchpad by visiting:
remote: https://code.launchpad.net/~bryce/ppa-dev-tools/+git/ppa-dev-tools-1/+ref/set-command/+register-merge
remote:
To git+ssh://git.launchpad.net/ppa-dev-tools
 * [new branch] set-command -> set-command

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: