ppa-dev-tools

Merge ppa-dev-tools:fix-lp1993368-cli-arg-behavior into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. fix-lp1993368-cli-arg-behavior
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 3296a991e53a7a9ad14c378e0a35e03fbc350a19
Proposed branch: ppa-dev-tools:fix-lp1993368-cli-arg-behavior
Merge into: ppa-dev-tools:main
Diff against target: 450 lines (+119/-71)
2 files modified
.flake8 (+1/-1)
scripts/ppa (+118/-70)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Canonical Server Reporter Pending
Review via email: mp+434224@code.staging.launchpad.net

Description of the change

Fixes for several bugs relating to the command line arg handling. Includes some lint/flake cleanup as well.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hey, looks 95% good and 5% like questions from me :-)
I've put them inline, anything (=most of it) I didn't mention LGTM.

My feedback might be considered preference/style - so I'm approving and it would be up to you to land it with or without the suggested changes.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review, I incorporated most of the changes Friday and will land this branch today.

I wanted to think more about the suggestion for a helper routine for creating the subparsers, but I think I'm going to hold off on that and see how the code evolves first. (There's going to be a bunch of subparser help text, and a bunch of repetitive cli options added, which may suggest a different refactoring approach.)

Revision history for this message
Bryce Harrington (bryce) wrote :

Enumerating objects: 29, done.
Counting objects: 100% (29/29), done.
Delta compression using up to 12 threads
Compressing objects: 100% (19/19), done.
Writing objects: 100% (25/25), 4.97 KiB | 2.49 MiB/s, done.
Total 25 (delta 13), reused 0 (delta 0)
To git+ssh://git.launchpad.net/ppa-dev-tools
   ec30901..01d9b53 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: