Merge ppa-dev-tools:tests-dashboard into ppa-dev-tools:main
| Status: | Merged |
|---|---|
| Approved by: | Bryce Harrington |
| Approved revision: | 81e5433dcb506903f321d6d0fb99a681f11991ba |
| Merge reported by: | Bryce Harrington |
| Merged at revision: | 81e5433dcb506903f321d6d0fb99a681f11991ba |
| Proposed branch: | ppa-dev-tools:tests-dashboard |
| Merge into: | ppa-dev-tools:main |
| Diff against target: |
963 lines (+363/-120) 16 files modified
NEWS.md (+7/-0) README.md (+24/-0) ppa/debug.py (+14/-8) ppa/job.py (+20/-20) ppa/ppa.py (+16/-3) ppa/ppa_group.py (+15/-7) ppa/result.py (+11/-6) ppa/subtest.py (+7/-4) ppa/text.py (+14/-29) ppa/trigger.py (+5/-3) scripts/ppa (+92/-34) tests/test_job.py (+2/-2) tests/test_ppa_group.py (+6/-1) tests/test_result.py (+1/-1) tests/test_scripts_ppa.py (+75/-2) tests/test_text.py (+54/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Athos Ribeiro (community) | Approve | ||
| Ubuntu Server | Pending | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
I am still running a version of terminator that does not support the
ansi hyperlink functionality, and for that reason was planning on
implementing something to test the terminal for support, and make
`ppa tests` automatically format links.
However, in researching into it, I see that once I upgrade to jammy's
version of Terminator I'll have the support, and a lot of other terminal
programs also already include it now. Furthermore, I've failed to find
if there's a provided way to check for support, other than just looking
up the terminal program's version number against a known-good list.
So rather than bother with all that logic (that'll become less and less
necessary over time), I'll just follow lp-test-ppa's solution of relying
on commandline params / config values for users to manually select what
they want, and leave it at that.
Anyway, by and large this is derivative of lp-test-ppa's output
formatting, but I've added some refinements. First, I've structured
the bulleting to follow the style we use in changelog entries (I like it).
I've attempted to condense the amount of output by eliminating redundant
text, re-ordering how things are displayed, and filtering out stuff I
think users won't care about. Likely, this will all require further
refinement, but the ultimate goal is to provide a convenient
dashboard-like view.
Beyond that, this also includes a variety of random fixes and cleanups
discovered during the preparation of this branch. Hopefully nothing
that causes too much distraction. Most notable of these is a fix for
the rather rare situation we're in where the old devel release is no
longer under development, but the next development release hasn't
opened.
| Bryce Harrington (bryce) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Hi Bryce! Nice work :)
This LGTM. I added a few inline comments below. As usual, feel free to ignore/act upon them as you please, since they are mostly minor nitpicks.
For large patch sets, it would be nice to have refactoring changes in their own commits.
For instance, bfd3865 is described as a test change/